Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Toggling server_side_encryption.enabled should recreate cluster. #5664

Merged
merged 1 commit into from
Aug 23, 2018
Merged

Toggling server_side_encryption.enabled should recreate cluster. #5664

merged 1 commit into from
Aug 23, 2018

Conversation

ewbankkit
Copy link
Contributor

Fix #5662.

Acceptance tests:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSDAXCluster_encryption'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -run=TestAccAWSDAXCluster_encryption -timeout 120m
=== RUN   TestAccAWSDAXCluster_encryption_disabled
--- PASS: TestAccAWSDAXCluster_encryption_disabled (641.17s)
=== RUN   TestAccAWSDAXCluster_encryption_enabled
--- PASS: TestAccAWSDAXCluster_encryption_enabled (660.80s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	1301.981s

bflad
bflad approved these changes Aug 23, 2018
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, sorry for the omission when simplifying the code.

@bflad bflad added this to the v1.34.0 milestone Aug 23, 2018
@bflad bflad added bug Addresses a defect in current functionality. service/dax Issues and PRs that pertain to the dax service. labels Aug 23, 2018
@bflad bflad merged commit 6e1bdbb into hashicorp:master Aug 23, 2018
bflad added a commit that referenced this pull request Aug 23, 2018
@bflad
Update CHANGELOG for #5664
3a30cb7
@ewbankkit ewbankkit deleted the issue-5662 branch August 23, 2018 16:51
@bflad
Copy link
Contributor

bflad commented Aug 30, 2018

This has been released in version 1.34.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ghost
Copy link

ghost commented Apr 3, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bflad bflad bflad approved these changes

Assignees
No one assigned
Labels
bug Addresses a defect in current functionality. service/dax Issues and PRs that pertain to the dax service.
Projects
None yet
Milestone
v1.34.0
Development

Successfully merging this pull request may close these issues.

r/aws_dax_cluster: Toggling server_side_encryption.enabled should recreate cluster
2 participants
@ewbankkit @bflad