-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add include body for lambda function association #5681
Add include body for lambda function association #5681
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @parabolic! 🚀
12 tests passed (all tests)
--- PASS: TestAccAWSCloudFrontDistribution_Origin_EmptyDomainName (1.36s)
--- PASS: TestAccAWSCloudFrontDistribution_Origin_EmptyOriginID (1.49s)
--- PASS: TestAccAWSCloudFrontDistribution_S3Origin (1512.80s)
--- PASS: TestAccAWSCloudFrontDistribution_HTTP11Config (1513.44s)
--- PASS: TestAccAWSCloudFrontDistribution_noOptionalItemsConfig (1513.56s)
--- PASS: TestAccAWSCloudFrontDistribution_S3OriginWithTags (1516.36s)
--- PASS: TestAccAWSCloudFrontDistribution_noCustomErrorResponseConfig (1516.43s)
--- PASS: TestAccAWSCloudFrontDistribution_orderedCacheBehavior (1518.41s)
--- PASS: TestAccAWSCloudFrontDistribution_importBasic (1520.43s)
--- PASS: TestAccAWSCloudFrontDistribution_customOrigin (1521.48s)
--- PASS: TestAccAWSCloudFrontDistribution_multiOrigin (1521.63s)
--- PASS: TestAccAWSCloudFrontDistribution_IsIPV6EnabledConfig (1522.50s)
🎉 Great, thanks @bflad! |
This has been released in version 1.36.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
Changes proposed in this pull request:
Adding support for
IncludeBody
option to thelambda_function_association
in cloudfront which is not supported by the terraform-provider-aws for using the lamda@edge implementation.Here's an excerpt form the documentation:
include_body
parameter in thelambda_function_association
in thecloudfront
resource and set the default to false.Example taken from the web console can be seen here:
Output from acceptance testing:
please note that I had to manually adjust the timeout to 1000m because the tests where timing out due to cloudfront being slow