Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource/aws_codebuild_project: Support secondary artifacts and secondary sources #5939

Merged
merged 2 commits into from
Sep 20, 2018

Conversation

marcoreni
Copy link
Contributor

Related issue: #5826
This PR adds necessary attributes to AWS CodeBuild. Since it's my first contribution, be kind :D

Changes proposed in this pull request:

  • resource/aws_codebuild_project: new secondary_artifacts and secondary_sources attributes
  • resource/aws_codebuild_project: added acceptance tests
  • resource/aws_codebuild_project: updated documentation

Output from acceptance testing:

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSCodeBuildProject_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -run=TestAccAWSCodeBuildProject_ -timeout 120m
=== RUN   TestAccAWSCodeBuildProject_importBasic
--- PASS: TestAccAWSCodeBuildProject_importBasic (54.28s)
=== RUN   TestAccAWSCodeBuildProject_basic
--- PASS: TestAccAWSCodeBuildProject_basic (44.38s)
=== RUN   TestAccAWSCodeBuildProject_BadgeEnabled
--- PASS: TestAccAWSCodeBuildProject_BadgeEnabled (39.50s)
=== RUN   TestAccAWSCodeBuildProject_BuildTimeout
--- PASS: TestAccAWSCodeBuildProject_BuildTimeout (59.28s)
=== RUN   TestAccAWSCodeBuildProject_Cache
--- PASS: TestAccAWSCodeBuildProject_Cache (253.37s)
=== RUN   TestAccAWSCodeBuildProject_Description
--- PASS: TestAccAWSCodeBuildProject_Description (63.74s)
=== RUN   TestAccAWSCodeBuildProject_EncryptionKey
--- PASS: TestAccAWSCodeBuildProject_EncryptionKey (189.51s)
=== RUN   TestAccAWSCodeBuildProject_Environment_EnvironmentVariable_Type
--- PASS: TestAccAWSCodeBuildProject_Environment_EnvironmentVariable_Type (65.16s)
=== RUN   TestAccAWSCodeBuildProject_Source_Auth
--- PASS: TestAccAWSCodeBuildProject_Source_Auth (39.55s)
=== RUN   TestAccAWSCodeBuildProject_Source_GitCloneDepth
--- PASS: TestAccAWSCodeBuildProject_Source_GitCloneDepth (69.81s)
=== RUN   TestAccAWSCodeBuildProject_Source_InsecureSSL
--- PASS: TestAccAWSCodeBuildProject_Source_InsecureSSL (163.56s)
=== RUN   TestAccAWSCodeBuildProject_Source_ReportBuildStatus
--- PASS: TestAccAWSCodeBuildProject_Source_ReportBuildStatus (65.51s)
=== RUN   TestAccAWSCodeBuildProject_Source_Type_Bitbucket
--- PASS: TestAccAWSCodeBuildProject_Source_Type_Bitbucket (43.69s)
=== RUN   TestAccAWSCodeBuildProject_Source_Type_CodeCommit
--- PASS: TestAccAWSCodeBuildProject_Source_Type_CodeCommit (43.35s)
=== RUN   TestAccAWSCodeBuildProject_Source_Type_CodePipeline
--- PASS: TestAccAWSCodeBuildProject_Source_Type_CodePipeline (39.25s)
=== RUN   TestAccAWSCodeBuildProject_Source_Type_GitHubEnterprise
--- PASS: TestAccAWSCodeBuildProject_Source_Type_GitHubEnterprise (161.17s)
=== RUN   TestAccAWSCodeBuildProject_Source_Type_S3
--- PASS: TestAccAWSCodeBuildProject_Source_Type_S3 (45.44s)
=== RUN   TestAccAWSCodeBuildProject_Tags
--- PASS: TestAccAWSCodeBuildProject_Tags (62.75s)
=== RUN   TestAccAWSCodeBuildProject_VpcConfig
--- PASS: TestAccAWSCodeBuildProject_VpcConfig (254.48s)
=== RUN   TestAccAWSCodeBuildProject_WindowsContainer
--- PASS: TestAccAWSCodeBuildProject_WindowsContainer (40.56s)
=== RUN   TestAccAWSCodeBuildProject_Artifacts_EncryptionDisabled
--- PASS: TestAccAWSCodeBuildProject_Artifacts_EncryptionDisabled (69.56s)
=== RUN   TestAccAWSCodeBuildProject_SecondaryArtifacts
--- PASS: TestAccAWSCodeBuildProject_SecondaryArtifacts (175.00s)
=== RUN   TestAccAWSCodeBuildProject_SecondarySources_CodeCommit
--- PASS: TestAccAWSCodeBuildProject_SecondarySources_CodeCommit (80.88s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       2125.347s

@ghost ghost added documentation Introduces or discusses updates to documentation. service/codebuild Issues and PRs that pertain to the codebuild service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/XL Managed by automation to categorize the size of a PR. labels Sep 20, 2018
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @marcoreni! 🚀

23 tests passed (all tests)
--- PASS: TestAccAWSCodeBuildProject_BadgeEnabled (17.15s)
--- PASS: TestAccAWSCodeBuildProject_Source_Type_CodeCommit (17.45s)
--- PASS: TestAccAWSCodeBuildProject_Source_Type_S3 (17.55s)
--- PASS: TestAccAWSCodeBuildProject_Source_ReportBuildStatus (21.44s)
--- PASS: TestAccAWSCodeBuildProject_Source_Type_CodePipeline (25.10s)
--- PASS: TestAccAWSCodeBuildProject_Source_Type_GitHubEnterprise (25.14s)
--- PASS: TestAccAWSCodeBuildProject_WindowsContainer (25.47s)
--- PASS: TestAccAWSCodeBuildProject_Source_Type_Bitbucket (25.85s)
--- PASS: TestAccAWSCodeBuildProject_Source_Auth (25.93s)
--- PASS: TestAccAWSCodeBuildProject_basic (26.05s)
--- PASS: TestAccAWSCodeBuildProject_importBasic (26.04s)
--- PASS: TestAccAWSCodeBuildProject_Tags (29.36s)
--- PASS: TestAccAWSCodeBuildProject_Source_GitCloneDepth (29.64s)
--- PASS: TestAccAWSCodeBuildProject_Source_InsecureSSL (29.99s)
--- PASS: TestAccAWSCodeBuildProject_Description (30.11s)
--- PASS: TestAccAWSCodeBuildProject_Environment_EnvironmentVariable_Type (30.30s)
--- PASS: TestAccAWSCodeBuildProject_BuildTimeout (30.59s)
--- PASS: TestAccAWSCodeBuildProject_EncryptionKey (34.50s)
--- PASS: TestAccAWSCodeBuildProject_VpcConfig (36.62s)
--- PASS: TestAccAWSCodeBuildProject_SecondarySources_CodeCommit (23.78s)
--- PASS: TestAccAWSCodeBuildProject_SecondaryArtifacts (24.20s)
--- PASS: TestAccAWSCodeBuildProject_Artifacts_EncryptionDisabled (24.73s)
--- PASS: TestAccAWSCodeBuildProject_Cache (42.85s)

@bflad bflad added this to the v1.38.0 milestone Sep 20, 2018
@bflad bflad merged commit 127dd3f into hashicorp:master Sep 20, 2018
bflad added a commit that referenced this pull request Sep 20, 2018
@bflad
Copy link
Contributor

bflad commented Sep 26, 2018

This has been released in version 1.38.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@marcoreni marcoreni deleted the feature/5826_codebuild branch May 6, 2019 09:54
@ghost
Copy link

ghost commented Mar 30, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. service/codebuild Issues and PRs that pertain to the codebuild service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants