Elastic Transcoder imports

[mbamber]

Changes proposed in this pull request:

• Allow importing of elastic transcoder pipelines
• Allow importing of elastic transcoder presets

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSElasticTranscoderPipeline_import'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -parallel 20 -run=TestAccAWSElasticTranscoderPipeline_import -timeout 120m
?   	github.com/terraform-providers/terraform-provider-aws	[no test files]
=== RUN   TestAccAWSElasticTranscoderPipeline_import
=== PAUSE TestAccAWSElasticTranscoderPipeline_import
=== CONT  TestAccAWSElasticTranscoderPipeline_import
--- PASS: TestAccAWSElasticTranscoderPipeline_import (62.68s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	62.725s

$ make testacc TESTARGS='-run=TestAccAWSElasticTranscoderPreset_import'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -parallel 20 -run=TestAccAWSElasticTranscoderPreset_import -timeout 120m
?   	github.com/terraform-providers/terraform-provider-aws	[no test files]
=== RUN   TestAccAWSElasticTranscoderPreset_import
=== PAUSE TestAccAWSElasticTranscoderPreset_import
=== CONT  TestAccAWSElasticTranscoderPreset_import
--- PASS: TestAccAWSElasticTranscoderPreset_import (27.19s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	(cached)
...

[mbamber]

Fixed the acceptance tests breaking when run in parallel

$ make testacc TESTARGS='-run=TestAccAWSElasticTranscoder'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -parallel 20 -run=TestAccAWSElasticTranscoder -timeout 120m
?   	github.com/terraform-providers/terraform-provider-aws	[no test files]
=== RUN   TestAccAWSElasticTranscoderPipeline_basic
=== PAUSE TestAccAWSElasticTranscoderPipeline_basic
=== RUN   TestAccAWSElasticTranscoderPipeline_kmsKey
=== PAUSE TestAccAWSElasticTranscoderPipeline_kmsKey
=== RUN   TestAccAWSElasticTranscoderPipeline_notifications
=== PAUSE TestAccAWSElasticTranscoderPipeline_notifications
=== RUN   TestAccAWSElasticTranscoderPipeline_withContentConfig
=== PAUSE TestAccAWSElasticTranscoderPipeline_withContentConfig
=== RUN   TestAccAWSElasticTranscoderPipeline_withPermissions
=== PAUSE TestAccAWSElasticTranscoderPipeline_withPermissions
=== RUN   TestAccAWSElasticTranscoderPipeline_import
=== PAUSE TestAccAWSElasticTranscoderPipeline_import
=== RUN   TestAccAWSElasticTranscoderPreset_import
=== PAUSE TestAccAWSElasticTranscoderPreset_import
=== RUN   TestAccAWSElasticTranscoderPreset_basic
=== PAUSE TestAccAWSElasticTranscoderPreset_basic
=== CONT  TestAccAWSElasticTranscoderPipeline_basic
=== CONT  TestAccAWSElasticTranscoderPipeline_import
=== CONT  TestAccAWSElasticTranscoderPipeline_withContentConfig
=== CONT  TestAccAWSElasticTranscoderPipeline_kmsKey
=== CONT  TestAccAWSElasticTranscoderPreset_import
=== CONT  TestAccAWSElasticTranscoderPipeline_notifications
=== CONT  TestAccAWSElasticTranscoderPreset_basic
=== CONT  TestAccAWSElasticTranscoderPipeline_withPermissions
--- PASS: TestAccAWSElasticTranscoderPreset_import (17.98s)
--- PASS: TestAccAWSElasticTranscoderPreset_basic (42.19s)
--- PASS: TestAccAWSElasticTranscoderPipeline_basic (43.06s)
--- PASS: TestAccAWSElasticTranscoderPipeline_withPermissions (47.41s)
--- PASS: TestAccAWSElasticTranscoderPipeline_kmsKey (70.69s)
--- PASS: TestAccAWSElasticTranscoderPipeline_import (73.81s)
--- PASS: TestAccAWSElasticTranscoderPipeline_withContentConfig (80.24s)
--- PASS: TestAccAWSElasticTranscoderPipeline_notifications (114.38s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	114.428s

[bflad]

LGTM, thanks @mbamber!! 🚀

One note is that we're looking to migrate away from import specific acceptance tests and instead just include the TestStep with ImportState: true, etc. in every test where it makes sense. This catches scenarios where an attribute may not be properly read into the Terraform state during the Read function and would show as a difference immediately after import. Since this effort is ongoing, we'll just include these tests in that effort of converting the testing if they aren't updated before then. 👍

--- PASS: TestAccAWSElasticTranscoderPreset_import (4.09s)
--- PASS: TestAccAWSElasticTranscoderPreset_basic (8.62s)
--- PASS: TestAccAWSElasticTranscoderPipeline_withPermissions (9.74s)
--- PASS: TestAccAWSElasticTranscoderPipeline_withContentConfig (10.34s)
--- PASS: TestAccAWSElasticTranscoderPipeline_notifications (10.66s)
--- PASS: TestAccAWSElasticTranscoderPipeline_basic (17.12s)
--- PASS: TestAccAWSElasticTranscoderPipeline_import (20.84s)
--- PASS: TestAccAWSElasticTranscoderPipeline_kmsKey (24.14s)

[bflad]

This has been released in version 1.44.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!