Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add aws_appmesh_virtual_node resource #6764

Merged
merged 1 commit into from
Dec 7, 2018

Conversation

ewbankkit
Copy link
Contributor

Related:

Acceptance tests:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSAppmesh'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -parallel 20 -run=TestAccAWSAppmesh -timeout 120m
=== RUN   TestAccAWSAppmesh
=== RUN   TestAccAWSAppmesh/Mesh
=== RUN   TestAccAWSAppmesh/Mesh/basic
=== RUN   TestAccAWSAppmesh/VirtualNode
=== RUN   TestAccAWSAppmesh/VirtualNode/basic
=== RUN   TestAccAWSAppmesh/VirtualNode/allAttributes
=== RUN   TestAccAWSAppmesh/VirtualRouter
=== RUN   TestAccAWSAppmesh/VirtualRouter/basic
--- PASS: TestAccAWSAppmesh (78.58s)
    --- PASS: TestAccAWSAppmesh/Mesh (14.32s)
        --- PASS: TestAccAWSAppmesh/Mesh/basic (14.32s)
    --- PASS: TestAccAWSAppmesh/VirtualNode (40.25s)
        --- PASS: TestAccAWSAppmesh/VirtualNode/basic (14.65s)
        --- PASS: TestAccAWSAppmesh/VirtualNode/allAttributes (25.60s)
    --- PASS: TestAccAWSAppmesh/VirtualRouter (24.00s)
        --- PASS: TestAccAWSAppmesh/VirtualRouter/basic (24.00s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	78.595s

@ghost ghost added size/XL Managed by automation to categorize the size of a PR. provider Pertains to the provider itself, rather than any interaction with AWS. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. documentation Introduces or discusses updates to documentation. labels Dec 7, 2018
@bflad bflad added new-resource Introduces a new resource. service/appmesh Issues and PRs that pertain to the appmesh service. labels Dec 7, 2018
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @ewbankkit 🚀

--- PASS: TestAccAWSAppmesh (19.09s)
    --- PASS: TestAccAWSAppmesh/Mesh (3.93s)
        --- PASS: TestAccAWSAppmesh/Mesh/basic (3.93s)
    --- PASS: TestAccAWSAppmesh/VirtualNode (9.23s)
        --- PASS: TestAccAWSAppmesh/VirtualNode/basic (3.43s)
        --- PASS: TestAccAWSAppmesh/VirtualNode/allAttributes (5.80s)
    --- PASS: TestAccAWSAppmesh/VirtualRouter (5.93s)
        --- PASS: TestAccAWSAppmesh/VirtualRouter/basic (5.93s)

@bflad bflad added this to the v1.52.0 milestone Dec 7, 2018
@bflad bflad merged commit 0e585e7 into hashicorp:master Dec 7, 2018
bflad added a commit that referenced this pull request Dec 7, 2018
@ewbankkit ewbankkit deleted the add-appmesh-virtual-node branch December 7, 2018 20:35
@bflad
Copy link
Contributor

bflad commented Dec 13, 2018

This has been released in version 1.52.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ghost
Copy link

ghost commented Apr 1, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. new-resource Introduces a new resource. provider Pertains to the provider itself, rather than any interaction with AWS. service/appmesh Issues and PRs that pertain to the appmesh service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants