Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Dedicated Host ID field to aws_instance resource #6767

Merged
merged 6 commits into from
Dec 13, 2018
Merged

Added Dedicated Host ID field to aws_instance resource #6767

merged 6 commits into from
Dec 13, 2018

Conversation

cfullerton
Copy link
Contributor

Fixes #0000

Changes proposed in this pull request:

  • Change 1
  • Change 2

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSAvailabilityZones'

...

@ghost ghost added size/XS Managed by automation to categorize the size of a PR. service/ec2 Issues and PRs that pertain to the ec2 service. labels Dec 7, 2018
bflad
bflad reviewed Dec 7, 2018
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for submitting this @cfullerton 👍 Please see the below initial feedback and let us know if you have any questions or do not have time to implement the items.

aws/data_source_aws_instance.go Outdated Show resolved Hide resolved
aws/data_source_aws_instance.go Show resolved Hide resolved
aws/resource_aws_instance.go Show resolved Hide resolved
@bflad bflad added enhancement Requests to existing resources that expand the functionality or scope. waiting-response Maintainers are waiting on response from community or contributor. labels Dec 7, 2018
@ghost ghost added size/S Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. documentation Introduces or discusses updates to documentation. and removed size/XS Managed by automation to categorize the size of a PR. labels Dec 7, 2018
@cfullerton
Copy link
Contributor Author

@bflad should I do something to move out of awaiting response (first timer).

@ghost ghost removed the waiting-response Maintainers are waiting on response from community or contributor. label Dec 7, 2018
bflad
bflad approved these changes Dec 13, 2018
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @cfullerton! 🚀

Passes all existing acceptance testing.

@bflad bflad added this to the v1.52.0 milestone Dec 13, 2018
@bflad bflad merged commit a558529 into hashicorp:master Dec 13, 2018
bflad added a commit that referenced this pull request Dec 13, 2018
@bflad
Update CHANGELOG for #6767
333f482
@bflad
Copy link
Contributor

bflad commented Dec 13, 2018

This has been released in version 1.52.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ghost
Copy link

ghost commented Apr 1, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bflad bflad bflad approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/ec2 Issues and PRs that pertain to the ec2 service. size/S Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v1.52.0
Development

Successfully merging this pull request may close these issues.
2 participants
@cfullerton @bflad