Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add support for eu-north-1 region #6836

Merged
merged 3 commits into from
Dec 13, 2018
Merged

add support for eu-north-1 region #6836

merged 3 commits into from
Dec 13, 2018

Conversation

sunilkumarmohanty
Copy link
Contributor

Fixes #6818

@ghost ghost added size/XS Managed by automation to categorize the size of a PR. service/cloudtrail Issues and PRs that pertain to the cloudtrail service. service/elb Issues and PRs that pertain to the elb service. labels Dec 12, 2018
@ghost ghost added size/S Managed by automation to categorize the size of a PR. and removed size/XS Managed by automation to categorize the size of a PR. labels Dec 12, 2018
@ewbankkit
Copy link
Contributor

Thanks. I think this also fixes #6832.

@ewbankkit
Copy link
Contributor

ewbankkit commented Dec 12, 2018 •
edited
Loading

@bflad Do we want to use the constants defined in the AWS SDK endpoints package instead of the string literals?
We could then have a test case for each region.

bflad
bflad reviewed Dec 13, 2018
View reviewed changes
aws/data_source_aws_elb_service_account.go Outdated Show resolved Hide resolved
aws/hosted_zones.go Show resolved Hide resolved
@bflad
Copy link
Contributor

bflad commented Dec 13, 2018

@bflad Do we want to use the constants defined in the AWS SDK endpoints package instead of the string literals?

I'm ambivalent either which way -- we may add information for AWS regions outside AWS Commercial, GovCloud (US), and China, which would not be present as constants in that file.

@bflad bflad added enhancement Requests to existing resources that expand the functionality or scope. service/s3 Issues and PRs that pertain to the s3 service. labels Dec 13, 2018
@bflad bflad added this to the v1.52.0 milestone Dec 13, 2018
bflad
bflad approved these changes Dec 13, 2018
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @sunilkumarmohanty! 🚀

@bflad bflad merged commit 490549e into hashicorp:master Dec 13, 2018
@bflad bflad mentioned this pull request Dec 13, 2018
Closed
bflad added a commit that referenced this pull request Dec 13, 2018
@bflad
Update CHANGELOG for #6836
21f8a55
@bflad
Copy link
Contributor

bflad commented Dec 13, 2018

This has been released in version 1.52.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ewbankkit ewbankkit mentioned this pull request Sep 17, 2019
Closed
@ghost
Copy link

ghost commented Apr 1, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bflad bflad bflad approved these changes

Assignees
No one assigned
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/cloudtrail Issues and PRs that pertain to the cloudtrail service. service/elb Issues and PRs that pertain to the elb service. service/s3 Issues and PRs that pertain to the s3 service. size/S Managed by automation to categorize the size of a PR.
Projects
None yet
Milestone
v1.52.0
Development

Successfully merging this pull request may close these issues.

Add support for region eu-north-1
3 participants
@sunilkumarmohanty @ewbankkit @bflad