r/aws_guardduty: Add argument finding_publishing_frequency to aws_guardduty_detector

[olemathias]

Changes proposed in this pull request:

• Add argument finding_publishing_frequency to aws_guardduty_detector
  https://docs.aws.amazon.com/guardduty/latest/ug/create-detector.html

Output from acceptance testing:

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSGuardDuty'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -parallel 20 -run=TestAccAWSGuardDuty -timeout 120m
=== RUN   TestAccAWSGuardDuty
=== RUN   TestAccAWSGuardDuty/Detector
=== RUN   TestAccAWSGuardDuty/Detector/import
=== RUN   TestAccAWSGuardDuty/Detector/basic
=== RUN   TestAccAWSGuardDuty/IPSet
=== RUN   TestAccAWSGuardDuty/IPSet/basic
=== RUN   TestAccAWSGuardDuty/IPSet/import
=== RUN   TestAccAWSGuardDuty/ThreatIntelSet
=== RUN   TestAccAWSGuardDuty/ThreatIntelSet/basic
=== RUN   TestAccAWSGuardDuty/ThreatIntelSet/import
=== RUN   TestAccAWSGuardDuty/Member
=== RUN   TestAccAWSGuardDuty/Member/basic
=== RUN   TestAccAWSGuardDuty/Member/inviteOnUpdate
=== RUN   TestAccAWSGuardDuty/Member/inviteDisassociate
=== RUN   TestAccAWSGuardDuty/Member/invitationMessage
--- PASS: TestAccAWSGuardDuty (290.22s)
    --- PASS: TestAccAWSGuardDuty/Detector (64.55s)
        --- PASS: TestAccAWSGuardDuty/Detector/import (16.73s)
        --- PASS: TestAccAWSGuardDuty/Detector/basic (47.83s)
    --- PASS: TestAccAWSGuardDuty/IPSet (104.54s)
        --- PASS: TestAccAWSGuardDuty/IPSet/basic (63.51s)
        --- PASS: TestAccAWSGuardDuty/IPSet/import (41.04s)
    --- PASS: TestAccAWSGuardDuty/ThreatIntelSet (101.92s)
        --- PASS: TestAccAWSGuardDuty/ThreatIntelSet/basic (63.08s)
        --- PASS: TestAccAWSGuardDuty/ThreatIntelSet/import (38.83s)
    --- PASS: TestAccAWSGuardDuty/Member (19.20s)
        --- PASS: TestAccAWSGuardDuty/Member/basic (19.20s)
        --- SKIP: TestAccAWSGuardDuty/Member/inviteOnUpdate (0.00s)
            resource_aws_guardduty_test.go:46: Environment variable AWS_GUARDDUTY_MEMBER_ACCOUNT_ID is not set. To properly test inviting GuardDuty member accounts, a valid AWS account ID must be provided.
        --- SKIP: TestAccAWSGuardDuty/Member/inviteDisassociate (0.00s)
            resource_aws_guardduty_test.go:46: Environment variable AWS_GUARDDUTY_MEMBER_ACCOUNT_ID is not set. To properly test inviting GuardDuty member accounts, a valid AWS account ID must be provided.
        --- SKIP: TestAccAWSGuardDuty/Member/invitationMessage (0.00s)
            resource_aws_guardduty_test.go:46: Environment variable AWS_GUARDDUTY_MEMBER_ACCOUNT_ID is not set. To properly test inviting GuardDuty member accounts, a valid AWS account ID must be provided.
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	290.233s

[bflad]

LGTM, thanks @olemathias! 🚀

[bflad]

Nit: We can use the AWS Go SDK provided constant here and add plan time validation for this attribute via:

Default: guardduty.FindingPublishingFrequencySixHours,
ValidateFunc: validation.StringInSlice([]string{
  guardduty.FindingPublishingFrequencyFifteenMinutes,
  guardduty.FindingPublishingFrequencyOneHour,
  guardduty.FindingPublishingFrequencySixHours
}, false),

[bflad]

This has been released in version 1.53.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!