Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DocumentDB: aws_docdb_cluster_snapshot resource added #7123

Merged
merged 2 commits into from
Feb 8, 2019
Merged

DocumentDB: aws_docdb_cluster_snapshot resource added #7123

merged 2 commits into from
Feb 8, 2019

Conversation

fewstera
Copy link
Contributor

This depends on my PR for aws_docdb_cluster (#7122) so must be merged after that.

This PR forms part of #7077.

Adds the aws_docdb_cluster_snapshot resource.

Output from acceptance testing:

make testacc TESTARGS='-run=TestAccAWSDocDBClusterSnapshot'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -parallel 20 -run=TestAccAWSDocDBClusterSnapshot -timeout 120m
?       github.com/terraform-providers/terraform-provider-aws   [no test files]
=== RUN   TestAccAWSDocDBClusterSnapshot_basic
=== PAUSE TestAccAWSDocDBClusterSnapshot_basic
=== CONT  TestAccAWSDocDBClusterSnapshot_basic
--- PASS: TestAccAWSDocDBClusterSnapshot_basic (255.01s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws   255.048s

@ghost ghost added size/XL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Jan 12, 2019
@fewstera fewstera force-pushed the aws_docdb_cluster_snapshot branch from 7a1b134 to 4f1273a Compare January 12, 2019 15:06
@bflad bflad added new-resource Introduces a new resource. service/docdb Issues and PRs that pertain to the docdb service. labels Jan 12, 2019
@ewbankkit ewbankkit mentioned this pull request Jan 12, 2019
Closed
@fewstera fewstera mentioned this pull request Jan 15, 2019
Merged
bflad
bflad reviewed Feb 4, 2019
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this as well, @fewstera! This one is in pretty good shape. After fixing the few minor items below and after we merge the aws_docdb_cluster resource, this should be good to get in.

aws/resource_aws_docdb_cluster_snapshot_test.go Outdated Show resolved Hide resolved
aws/resource_aws_docdb_cluster_snapshot_test.go Outdated Show resolved Hide resolved
website/docs/r/docdb_cluster_snapshot.html.markdown Show resolved Hide resolved
@bflad bflad added the waiting-response Maintainers are waiting on response from community or contributor. label Feb 4, 2019
@fewstera fewstera force-pushed the aws_docdb_cluster_snapshot branch from 4f1273a to 4b494a6 Compare February 7, 2019 11:33
@fewstera
Copy link
Contributor Author

fewstera commented Feb 7, 2019

Thank you for the review.

The results of the acceptance tests after the changes:

make testacc TESTARGS='-run=TestAccAWSDocDBClusterSnapshot_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -parallel 20 -run=TestAccAWSDocDBClusterSnapshot_ -timeout 120m
?       github.com/terraform-providers/terraform-provider-aws   [no test files]
=== RUN   TestAccAWSDocDBClusterSnapshot_basic
=== PAUSE TestAccAWSDocDBClusterSnapshot_basic
=== CONT  TestAccAWSDocDBClusterSnapshot_basic
--- PASS: TestAccAWSDocDBClusterSnapshot_basic (234.24s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       234.295s

@ghost ghost removed the waiting-response Maintainers are waiting on response from community or contributor. label Feb 7, 2019
bflad
bflad approved these changes Feb 8, 2019
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @fewstera! 🚀

--- PASS: TestAccAWSDocDBClusterSnapshot_basic (218.74s)

@bflad bflad added this to the v1.58.0 milestone Feb 8, 2019
@bflad bflad merged commit 4847736 into hashicorp:master Feb 8, 2019
bflad added a commit that referenced this pull request Feb 8, 2019
@bflad
Update CHANGELOG for #7123
c880666
@bflad
Copy link
Contributor

bflad commented Feb 8, 2019

This has been released in version 1.58.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ghost
Copy link

ghost commented Apr 1, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bflad bflad bflad approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. new-resource Introduces a new resource. provider Pertains to the provider itself, rather than any interaction with AWS. service/docdb Issues and PRs that pertain to the docdb service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v1.58.0
Development

Successfully merging this pull request may close these issues.
2 participants
@fewstera @bflad