DocumentDB: Added aws_docdb_cluster_instance resource

[fewstera]

This depends on my previous two PRs for DocumentDB (#7122 and #7123 ) so must be merged after those.

Forms part of #7077.

make testacc TESTARGS='-run=TestAccAWSDocDBClusterInstance_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -parallel 20 -run=TestAccAWSDocDBClusterInstance_ -timeout 120m
?       github.com/terraform-providers/terraform-provider-aws   [no test files]
=== RUN   TestAccAWSDocDBClusterInstance_importBasic
=== PAUSE TestAccAWSDocDBClusterInstance_importBasic
=== RUN   TestAccAWSDocDBClusterInstance_basic
=== PAUSE TestAccAWSDocDBClusterInstance_basic
=== RUN   TestAccAWSDocDBClusterInstance_az
=== PAUSE TestAccAWSDocDBClusterInstance_az
=== RUN   TestAccAWSDocDBClusterInstance_namePrefix
=== PAUSE TestAccAWSDocDBClusterInstance_namePrefix
=== RUN   TestAccAWSDocDBClusterInstance_generatedName
=== PAUSE TestAccAWSDocDBClusterInstance_generatedName
=== RUN   TestAccAWSDocDBClusterInstance_kmsKey
=== PAUSE TestAccAWSDocDBClusterInstance_kmsKey
=== RUN   TestAccAWSDocDBClusterInstance_disappears
=== PAUSE TestAccAWSDocDBClusterInstance_disappears
=== CONT  TestAccAWSDocDBClusterInstance_importBasic
=== CONT  TestAccAWSDocDBClusterInstance_generatedName
=== CONT  TestAccAWSDocDBClusterInstance_disappears
=== CONT  TestAccAWSDocDBClusterInstance_kmsKey
=== CONT  TestAccAWSDocDBClusterInstance_az
=== CONT  TestAccAWSDocDBClusterInstance_namePrefix
=== CONT  TestAccAWSDocDBClusterInstance_basic
--- PASS: TestAccAWSDocDBClusterInstance_disappears (653.00s)
--- PASS: TestAccAWSDocDBClusterInstance_namePrefix (692.17s)
--- PASS: TestAccAWSDocDBClusterInstance_importBasic (692.35s)
--- PASS: TestAccAWSDocDBClusterInstance_az (695.59s)
--- PASS: TestAccAWSDocDBClusterInstance_kmsKey (716.14s)
--- PASS: TestAccAWSDocDBClusterInstance_generatedName (736.72s)
--- PASS: TestAccAWSDocDBClusterInstance_basic (1378.75s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       1378.810s

[bflad]

Hey @fewstera this is ready for rebase and provided an initial review below. All pretty small stuff so should be fairly easy to get in. 😄 Thanks for these contributions!

[fewstera]

@bflad I think I've made all the changes requested.

I haven't had the chance to run the acceptance tests yet, I'm about to go out, so can't run them now, I will post the output when I get the chance.

Thanks again for checking the PR so thoroughly. 👍

[fewstera]

@bflad acceptance tests now passing.

 make testacc TESTARGS='-run=TestAccAWSDocDBClusterInstance_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -parallel 20 -run=TestAccAWSDocDBClusterInstance_ -timeout 120m
?       github.com/terraform-providers/terraform-provider-aws   [no test files]
=== RUN   TestAccAWSDocDBClusterInstance_basic
=== PAUSE TestAccAWSDocDBClusterInstance_basic
=== RUN   TestAccAWSDocDBClusterInstance_az
=== PAUSE TestAccAWSDocDBClusterInstance_az
=== RUN   TestAccAWSDocDBClusterInstance_namePrefix
=== PAUSE TestAccAWSDocDBClusterInstance_namePrefix
=== RUN   TestAccAWSDocDBClusterInstance_generatedName
=== PAUSE TestAccAWSDocDBClusterInstance_generatedName
=== RUN   TestAccAWSDocDBClusterInstance_kmsKey
=== PAUSE TestAccAWSDocDBClusterInstance_kmsKey
=== RUN   TestAccAWSDocDBClusterInstance_disappears
=== PAUSE TestAccAWSDocDBClusterInstance_disappears
=== CONT  TestAccAWSDocDBClusterInstance_basic
=== CONT  TestAccAWSDocDBClusterInstance_kmsKey
=== CONT  TestAccAWSDocDBClusterInstance_namePrefix
=== CONT  TestAccAWSDocDBClusterInstance_disappears
=== CONT  TestAccAWSDocDBClusterInstance_generatedName
=== CONT  TestAccAWSDocDBClusterInstance_az
--- PASS: TestAccAWSDocDBClusterInstance_disappears (651.45s)
--- PASS: TestAccAWSDocDBClusterInstance_az (657.06s)
--- PASS: TestAccAWSDocDBClusterInstance_generatedName (679.58s)
--- PASS: TestAccAWSDocDBClusterInstance_namePrefix (714.98s)
--- PASS: TestAccAWSDocDBClusterInstance_kmsKey (724.67s)
--- PASS: TestAccAWSDocDBClusterInstance_basic (1310.49s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       1310.539s

[bflad]

You are going to make a bunch of folks happy, @fewstera! LGTM. 🚀

--- PASS: TestAccAWSDocDBClusterInstance_disappears (658.86s)
--- PASS: TestAccAWSDocDBClusterInstance_namePrefix (666.71s)
--- PASS: TestAccAWSDocDBClusterInstance_az (694.22s)
--- PASS: TestAccAWSDocDBClusterInstance_kmsKey (702.83s)
--- PASS: TestAccAWSDocDBClusterInstance_generatedName (747.87s)
--- PASS: TestAccAWSDocDBClusterInstance_basic (1324.65s)

[bflad]

This has been released in version 1.59.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!