Update DynamoDB billing_mode

[nathmclean]

Fixes #7097

Ensure that capacity is included in request when switching billing_mode from PAY_PER_REQUEST to PROVISIONED

Fixes #0000

Changes proposed in this pull request:

• Ensure that capacity is included in request when switching billing_mode from PAY_PER_REQUEST to PROVISIONED

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSAvailabilityZones'

=== RUN   TestAccAWSDynamoDbTableItem_basic
=== PAUSE TestAccAWSDynamoDbTableItem_basic
=== RUN   TestAccAWSDynamoDbTableItem_rangeKey
=== PAUSE TestAccAWSDynamoDbTableItem_rangeKey
=== RUN   TestAccAWSDynamoDbTableItem_withMultipleItems
=== PAUSE TestAccAWSDynamoDbTableItem_withMultipleItems
=== RUN   TestAccAWSDynamoDbTableItem_update
=== PAUSE TestAccAWSDynamoDbTableItem_update
=== RUN   TestAccAWSDynamoDbTableItem_updateWithRangeKey
=== PAUSE TestAccAWSDynamoDbTableItem_updateWithRangeKey
=== RUN   TestAccAWSDynamoDbTable_importBasic
=== PAUSE TestAccAWSDynamoDbTable_importBasic
=== RUN   TestAccAWSDynamoDbTable_importTags
=== PAUSE TestAccAWSDynamoDbTable_importTags
=== RUN   TestAccAWSDynamoDbTable_importTimeToLive
=== PAUSE TestAccAWSDynamoDbTable_importTimeToLive
=== RUN   TestAccAWSDynamoDbTable_basic
=== PAUSE TestAccAWSDynamoDbTable_basic
=== RUN   TestAccAWSDynamoDbTable_extended
=== PAUSE TestAccAWSDynamoDbTable_extended
=== RUN   TestAccAWSDynamoDbTable_enablePitr
=== PAUSE TestAccAWSDynamoDbTable_enablePitr
=== RUN   TestAccAWSDynamoDbTable_BillingMode
=== PAUSE TestAccAWSDynamoDbTable_BillingMode
=== RUN   TestAccAWSDynamoDbTable_BillingModeUpdate
=== PAUSE TestAccAWSDynamoDbTable_BillingModeUpdate
=== RUN   TestAccAWSDynamoDbTable_streamSpecification
=== PAUSE TestAccAWSDynamoDbTable_streamSpecification
=== RUN   TestAccAWSDynamoDbTable_streamSpecificationValidation
=== PAUSE TestAccAWSDynamoDbTable_streamSpecificationValidation
=== RUN   TestAccAWSDynamoDbTable_tags
=== PAUSE TestAccAWSDynamoDbTable_tags
=== RUN   TestAccAWSDynamoDbTable_gsiUpdateCapacity
=== PAUSE TestAccAWSDynamoDbTable_gsiUpdateCapacity
=== RUN   TestAccAWSDynamoDbTable_gsiUpdateOtherAttributes
=== PAUSE TestAccAWSDynamoDbTable_gsiUpdateOtherAttributes
=== RUN   TestAccAWSDynamoDbTable_gsiUpdateNonKeyAttributes
=== PAUSE TestAccAWSDynamoDbTable_gsiUpdateNonKeyAttributes
=== RUN   TestAccAWSDynamoDbTable_ttl
=== PAUSE TestAccAWSDynamoDbTable_ttl
=== RUN   TestAccAWSDynamoDbTable_attributeUpdate
=== PAUSE TestAccAWSDynamoDbTable_attributeUpdate
=== RUN   TestAccAWSDynamoDbTable_attributeUpdateValidation
=== PAUSE TestAccAWSDynamoDbTable_attributeUpdateValidation
=== RUN   TestAccAWSDynamoDbTable_encryption
=== PAUSE TestAccAWSDynamoDbTable_encryption
=== CONT  TestAccAWSDynamoDbTableItem_basic
=== CONT  TestAccAWSDynamoDbTable_gsiUpdateCapacity
=== CONT  TestAccAWSDynamoDbTable_gsiUpdateNonKeyAttributes
=== CONT  TestAccAWSDynamoDbTable_gsiUpdateOtherAttributes
=== CONT  TestAccAWSDynamoDbTable_encryption
=== CONT  TestAccAWSDynamoDbTable_attributeUpdateValidation
=== CONT  TestAccAWSDynamoDbTable_attributeUpdate
=== CONT  TestAccAWSDynamoDbTable_BillingModeUpdate
--- PASS: TestAccAWSDynamoDbTable_attributeUpdateValidation (5.62s)
=== CONT  TestAccAWSDynamoDbTable_ttl
--- PASS: TestAccAWSDynamoDbTable_ttl (101.56s)
=== CONT  TestAccAWSDynamoDbTable_streamSpecificationValidation
--- PASS: TestAccAWSDynamoDbTable_streamSpecificationValidation (3.67s)
=== CONT  TestAccAWSDynamoDbTable_streamSpecification
--- PASS: TestAccAWSDynamoDbTableItem_basic (125.93s)
=== CONT  TestAccAWSDynamoDbTable_tags
--- PASS: TestAccAWSDynamoDbTable_BillingModeUpdate (155.03s)
=== CONT  TestAccAWSDynamoDbTable_importTags
--- PASS: TestAccAWSDynamoDbTable_gsiUpdateNonKeyAttributes (228.25s)
=== CONT  TestAccAWSDynamoDbTableItem_update
--- PASS: TestAccAWSDynamoDbTable_gsiUpdateCapacity (242.30s)
=== CONT  TestAccAWSDynamoDbTable_BillingMode
--- PASS: TestAccAWSDynamoDbTable_encryption (249.74s)
=== CONT  TestAccAWSDynamoDbTable_importBasic
--- PASS: TestAccAWSDynamoDbTable_tags (138.77s)
=== CONT  TestAccAWSDynamoDbTable_enablePitr
--- PASS: TestAccAWSDynamoDbTable_streamSpecification (162.65s)
=== CONT  TestAccAWSDynamoDbTableItem_updateWithRangeKey
--- PASS: TestAccAWSDynamoDbTable_importTags (151.81s)
=== CONT  TestAccAWSDynamoDbTable_extended
--- PASS: TestAccAWSDynamoDbTableItem_update (141.01s)
=== CONT  TestAccAWSDynamoDbTableItem_withMultipleItems
--- PASS: TestAccAWSDynamoDbTable_importBasic (150.88s)
=== CONT  TestAccAWSDynamoDbTable_basic
--- PASS: TestAccAWSDynamoDbTableItem_updateWithRangeKey (140.50s)
=== CONT  TestAccAWSDynamoDbTableItem_rangeKey
--- PASS: TestAccAWSDynamoDbTableItem_withMultipleItems (127.45s)
=== CONT  TestAccAWSDynamoDbTable_importTimeToLive
--- PASS: TestAccAWSDynamoDbTable_basic (120.45s)
--- PASS: TestAccAWSDynamoDbTable_BillingMode (292.59s)
--- PASS: TestAccAWSDynamoDbTableItem_rangeKey (122.47s)
--- PASS: TestAccAWSDynamoDbTable_gsiUpdateOtherAttributes (539.11s)
--- PASS: TestAccAWSDynamoDbTable_attributeUpdate (540.93s)
--- PASS: TestAccAWSDynamoDbTable_extended (236.27s)
--- PASS: TestAccAWSDynamoDbTable_importTimeToLive (143.15s)
--- PASS: TestAccAWSDynamoDbTable_enablePitr (550.55s)
PASS
ok      github.com/nathmclean/terraform-provider-aws/aws        815.296s
...

[bflad]

Thanks so much for this fix and the additional acceptance test, @nathmclean! I verified the old test fails and the updated behavior passes acceptance testing.

--- PASS: TestAccAWSDynamoDbTable_streamSpecificationValidation (2.85s)
--- PASS: TestAccAWSDynamoDbTable_attributeUpdateValidation (3.20s)
--- PASS: TestAccAWSDynamoDbTable_importTags (39.86s)
--- PASS: TestAccAWSDynamoDbTable_disappears (110.35s)
--- PASS: TestAccAWSDynamoDbTable_basic (111.12s)
--- PASS: TestAccAWSDynamoDbTable_BillingModeUpdate (126.45s)
--- PASS: TestAccAWSDynamoDbTable_streamSpecification (126.92s)
--- PASS: TestAccAWSDynamoDbTable_importBasic (130.73s)
--- PASS: TestAccAWSDynamoDbTable_importTimeToLive (131.45s)
--- PASS: TestAccAWSDynamoDbTable_ttl (134.54s)
--- PASS: TestAccAWSDynamoDbTable_gsiUpdateCapacity (138.45s)
--- PASS: TestAccAWSDynamoDbTable_tags (151.39s)
--- PASS: TestAccAWSDynamoDbTable_disappears_PayPerRequestWithGSI (182.61s)
--- PASS: TestAccAWSDynamoDbTable_encryption (252.35s)
--- PASS: TestAccAWSDynamoDbTable_enablePitr (364.46s)
--- PASS: TestAccAWSDynamoDbTable_BillingMode (365.55s)
--- PASS: TestAccAWSDynamoDbTable_gsiUpdateNonKeyAttributes (373.85s)
--- PASS: TestAccAWSDynamoDbTable_extended (374.08s)
--- PASS: TestAccAWSDynamoDbTable_attributeUpdate (683.86s)
--- PASS: TestAccAWSDynamoDbTable_gsiUpdateOtherAttributes (686.91s)

[bflad]

This has been released in version 1.58.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!