-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
resource/aws_elasticache_cluster: Remove deprecated availability_zones argument #7714
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s argument Reference: #7689 Output from acceptance testing: ``` --- PASS: TestAccAWSElasticacheCluster_AZMode_Redis_Ec2Classic (461.78s) --- PASS: TestAccAWSElasticacheCluster_Engine_Memcached_Ec2Classic (714.33s) --- PASS: TestAccAWSElasticacheCluster_Engine_Redis_Ec2Classic (572.93s) --- PASS: TestAccAWSElasticacheCluster_EngineVersion_Memcached_Ec2Classic (1220.84s) --- PASS: TestAccAWSElasticacheCluster_EngineVersion_Redis_Ec2Classic (1467.78s) --- PASS: TestAccAWSElasticacheCluster_multiAZInVpc (743.94s) --- PASS: TestAccAWSElasticacheCluster_NodeTypeResize_Memcached_Ec2Classic (924.84s) --- PASS: TestAccAWSElasticacheCluster_NodeTypeResize_Redis_Ec2Classic (991.05s) --- PASS: TestAccAWSElasticacheCluster_NumCacheNodes_Decrease (789.71s) --- PASS: TestAccAWSElasticacheCluster_NumCacheNodes_Increase (983.93s) --- PASS: TestAccAWSElasticacheCluster_NumCacheNodes_IncreaseWithPreferredAvailabilityZones (984.32s) --- PASS: TestAccAWSElasticacheCluster_NumCacheNodes_Redis_Ec2Classic (2.75s) --- PASS: TestAccAWSElasticacheCluster_ParameterGroupName_Default (575.89s) --- PASS: TestAccAWSElasticacheCluster_Port_Ec2Classic (572.71s) --- PASS: TestAccAWSElasticacheCluster_ReplicationGroupID_AvailabilityZone_Ec2Classic (1174.26s) --- PASS: TestAccAWSElasticacheCluster_ReplicationGroupID_InvalidAttributes (2.46s) --- PASS: TestAccAWSElasticacheCluster_ReplicationGroupID_MultipleReplica_Ec2Classic (1235.85s) --- PASS: TestAccAWSElasticacheCluster_ReplicationGroupID_SingleReplica_Ec2Classic (1133.99s) --- PASS: TestAccAWSElasticacheCluster_SecurityGroup (547.40s) --- PASS: TestAccAWSElasticacheCluster_snapshotsWithUpdates (1342.77s) --- PASS: TestAccAWSElasticacheCluster_vpc (633.71s) ```
bflad
added
breaking-change
Introduces a breaking change in current functionality; usually deferred to the next major release.
service/elasticache
Issues and PRs that pertain to the elasticache service.
technical-debt
Addresses areas of the codebase that need refactoring or redesign.
labels
Feb 25, 2019
ghost
added
size/XS
Managed by automation to categorize the size of a PR.
tests
PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
documentation
Introduces or discusses updates to documentation.
labels
Feb 25, 2019
nywilken
approved these changes
Feb 25, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
bflad
added a commit
that referenced
this pull request
Feb 26, 2019
bflad
added a commit
that referenced
this pull request
Feb 26, 2019
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
ghost
locked and limited conversation to collaborators
Mar 31, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
breaking-change
Introduces a breaking change in current functionality; usually deferred to the next major release.
documentation
Introduces or discusses updates to documentation.
service/elasticache
Issues and PRs that pertain to the elasticache service.
size/XS
Managed by automation to categorize the size of a PR.
technical-debt
Addresses areas of the codebase that need refactoring or redesign.
tests
PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7689
Output from acceptance testing: