Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new intervals to dlm #7751

Merged
merged 1 commit into from
Mar 1, 2019
Merged

Add new intervals to dlm #7751

merged 1 commit into from
Mar 1, 2019

Conversation

blckct
Copy link
Contributor

@blckct blckct commented Feb 27, 2019

Fixes #7749

Changes proposed in this pull request:

  • Add new intervals for AWS DLM
  • Change 2

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSDlmLifecyclePolicy_Basic' && $ make testacc TESTARGS='-run=TestAccAWSDlmLifecyclePolicy_Full'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -parallel 20 -run=TestAccAWSDlmLifecyclePolicy_Basic -timeout 120m
?       github.com/terraform-providers/terraform-provider-aws   [no test files]
=== RUN   TestAccAWSDlmLifecyclePolicy_Basic
=== PAUSE TestAccAWSDlmLifecyclePolicy_Basic
=== CONT  TestAccAWSDlmLifecyclePolicy_Basic
--- PASS: TestAccAWSDlmLifecyclePolicy_Basic (37.84s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       56.064s
...

@ghost ghost added size/XS Managed by automation to categorize the size of a PR. service/dlm Issues and PRs that pertain to the dlm service. labels Feb 27, 2019
@bflad bflad added the enhancement Requests to existing resources that expand the functionality or scope. label Mar 1, 2019
@bflad bflad added this to the v2.1.0 milestone Mar 1, 2019
bflad
bflad approved these changes Mar 1, 2019
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM according to the DLM API Reference and this shouldn't require additional acceptance testing. Thanks, @blckct! 🚀

@bflad bflad merged commit 0f80366 into hashicorp:master Mar 1, 2019
bflad added a commit that referenced this pull request Mar 1, 2019
@bflad
Update CHANGELOG for #7751
3ed1363
@bflad
Copy link
Contributor

bflad commented Mar 8, 2019

This has been released in version 2.1.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

MartinSedgewick added a commit to MartinSedgewick/terraform-provider-aws that referenced this pull request Apr 6, 2019
@MartinSedgewick
dlm_lifecycle_policy.markdown - added newer intervals
e6fc038 
2,3,4,6,8 have been added to the intervals.

This was introduced in 2.1

Addresses changes to code in hashicorp#7751
This was referenced Apr 6, 2019
Closed
Merged
@blckct blckct deleted the aws_dlm_new_intervals branch May 26, 2019 22:54
@ghost
Copy link

ghost commented Mar 29, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bflad bflad bflad approved these changes

Assignees
No one assigned
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/dlm Issues and PRs that pertain to the dlm service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Milestone
v2.1.0
Development

Successfully merging this pull request may close these issues.

Update aws_dlm_lifecycle_manager intervals
2 participants
@blckct @bflad