Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support tags attribute for resource_aws_media_package_channel #7984

Conversation

teraken0509
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Fixes #7813

Changes proposed in this pull request:

  • Add support tags attribute

Output from acceptance testing:

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSMediaPackageChannel_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -parallel 20 -run=TestAccAWSMediaPackageChannel_ -timeout 120m
=== RUN   TestAccAWSMediaPackageChannel_basic
=== PAUSE TestAccAWSMediaPackageChannel_basic
=== RUN   TestAccAWSMediaPackageChannel_description
=== PAUSE TestAccAWSMediaPackageChannel_description
=== RUN   TestAccAWSMediaPackageChannel_tags
=== PAUSE TestAccAWSMediaPackageChannel_tags
=== CONT  TestAccAWSMediaPackageChannel_basic
=== CONT  TestAccAWSMediaPackageChannel_description
=== CONT  TestAccAWSMediaPackageChannel_tags
--- PASS: TestAccAWSMediaPackageChannel_basic (35.25s)
--- PASS: TestAccAWSMediaPackageChannel_description (56.33s)
--- PASS: TestAccAWSMediaPackageChannel_tags (79.10s)
PASS
ok  	github.com/terraform-providers/tmp-terraform-provider-aws/aws	79.216s

@ghost ghost added size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. documentation Introduces or discusses updates to documentation. labels Mar 18, 2019
@bflad bflad added enhancement Requests to existing resources that expand the functionality or scope. service/mediapackage Issues and PRs that pertain to the mediapackage service. labels Mar 18, 2019
@bflad bflad added this to the v2.3.0 milestone Mar 18, 2019
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks @kterada0509 🚀 (TravisCI failures related to #7993)

--- PASS: TestAccAWSMediaPackageChannel_basic (20.26s)
--- PASS: TestAccAWSMediaPackageChannel_description (31.86s)
--- PASS: TestAccAWSMediaPackageChannel_tags (37.71s)

@bflad bflad merged commit b36ffe8 into hashicorp:master Mar 18, 2019
bflad added a commit that referenced this pull request Mar 18, 2019
@bflad
Copy link
Contributor

bflad commented Mar 21, 2019

This has been released in version 2.3.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@teraken0509 teraken0509 deleted the feature/add-tags-support-for-resource_aws_media_package_channel-resource branch March 5, 2020 14:05
@ghost
Copy link

ghost commented Mar 5, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/mediapackage Issues and PRs that pertain to the mediapackage service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AWS Elemental MediaPackage resources: Add support for resource tags
2 participants