Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource/aws_vpn_connection: Add transit_gateway_attachment_id attribute #8070

Merged
merged 1 commit into from
Mar 25, 2019

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Mar 25, 2019

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Reference: #6884

Only performs lookup when the VPN Connection has an associated Transit Gateway ID. I tried unsuccessfully to use a EC2 Transit Gateway shared via Resource Access Manager (RAM) in EC2 VPN Connection creation and it always returned the below error even after waiting for greater than 10 minutes and in the web console manually as well:

InvalidTransitGatewayID.NotFound: The transitGateway ID 'tgw-XXXXXXXXX' does not exist

This broken acceptance testing is omitted from this change request as it may not be functionality actually supported by EC2. If there is a working configuration with shared Transit Gateways, we may need to lean on additional feedback after this implementation to smooth over those issues.

Output from acceptance testing:

--- PASS: TestAccAWSVpnConnection_basic (617.58s)
--- PASS: TestAccAWSVpnConnection_disappears (426.58s)
--- PASS: TestAccAWSVpnConnection_importBasic (238.20s)
--- PASS: TestAccAWSVpnConnection_TransitGatewayID (439.63s)
--- PASS: TestAccAWSVpnConnection_tunnelOptions (269.52s)
--- PASS: TestAccAWSVpnConnection_withoutStaticRoutes (195.55s)

Reference: #6884

Only performs lookup when the VPN Connection has an associated Transit Gateway ID. I tried unsuccessfully to use a EC2 Transit Gateway shared via Resource Access Manager (RAM) in EC2 VPN Connection creation and it always returned the below error even after waiting for greater than 10 minutes and in the web console manually as well:

```
InvalidTransitGatewayID.NotFound: The transitGateway ID 'tgw-XXXXXXXXX' does not exist
```

This broken acceptance testing is omitted from this change request as it may not be functionality actually supported by EC2. If there is a working configuration with shared Transit Gateways, we may need to lean on additional feedback after this implementation to smooth over those issues.

Output from acceptance testing:

```
--- PASS: TestAccAWSVpnConnection_basic (617.58s)
--- PASS: TestAccAWSVpnConnection_disappears (426.58s)
--- PASS: TestAccAWSVpnConnection_importBasic (238.20s)
--- PASS: TestAccAWSVpnConnection_TransitGatewayID (439.63s)
--- PASS: TestAccAWSVpnConnection_tunnelOptions (269.52s)
--- PASS: TestAccAWSVpnConnection_withoutStaticRoutes (195.55s)
```
@bflad bflad added enhancement Requests to existing resources that expand the functionality or scope. service/ec2 Issues and PRs that pertain to the ec2 service. labels Mar 25, 2019
@bflad bflad requested a review from a team March 25, 2019 18:05
@ghost ghost added size/M Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Mar 25, 2019
@soumitmishra
Copy link

+1

Copy link
Contributor

@nywilken nywilken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LijieZhou
Copy link

+1

@bflad bflad added this to the v2.4.0 milestone Mar 25, 2019
@bflad bflad merged commit b89693a into master Mar 25, 2019
@bflad bflad deleted the f-aws_vpn_connection-transit_gateway_attachment_id branch March 25, 2019 23:50
bflad added a commit that referenced this pull request Mar 25, 2019
@bflad
Copy link
Contributor Author

bflad commented Mar 29, 2019

This has been released in version 2.4.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ghost
Copy link

ghost commented Mar 30, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/ec2 Issues and PRs that pertain to the ec2 service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants