service/secretsmanager: Handle additional scheduled/marked for deletion error messages #8219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eletion InvalidRequestException error during immediate recreation
Previous output from acceptance testing:
```
--- FAIL: TestAccAwsSecretsManagerSecret_RecoveryWindowInDays_Recreate (6.87s)
testing.go:538: Step 1 error: Error applying: 1 error occurred:
* aws_secretsmanager_secret.test: 1 error occurred:
* aws_secretsmanager_secret.test: error creating Secrets Manager Secret: InvalidRequestException: You can't create this secret because a secret with this name is already scheduled for deletion.
```
Output from acceptance testing:
```
--- PASS: TestAccAwsSecretsManagerSecret_policy (10.63s)
--- PASS: TestAccAwsSecretsManagerSecret_Basic (11.18s)
--- PASS: TestAccAwsSecretsManagerSecret_withNamePrefix (11.23s)
--- PASS: TestAccAwsSecretsManagerSecret_Description (19.12s)
--- PASS: TestAccAwsSecretsManagerSecret_Tags (33.62s)
--- PASS: TestAccAwsSecretsManagerSecret_RecoveryWindowInDays_Recreate (45.49s)
--- PASS: TestAccAwsSecretsManagerSecret_RotationLambdaARN (46.06s)
--- PASS: TestAccAwsSecretsManagerSecret_RotationRules (48.05s)
--- PASS: TestAccAwsSecretsManagerSecret_KmsKeyID (50.75s)
```
…arked for deletion InvalidRequestException error during CheckDestroy
Previous output from acceptance testing:
```
--- FAIL: TestAccAwsSecretsManagerSecretVersion_Base64Binary (7.05s)
testing.go:599: Error destroying resource! WARNING: Dangling resources
may exist. The full state and error is shown below.
Error: Check failed: InvalidRequestException: You can’t perform this operation on the secret because it was marked for deletion.
--- FAIL: TestAccAwsSecretsManagerSecretVersion_BasicString (6.82s)
testing.go:599: Error destroying resource! WARNING: Dangling resources
may exist. The full state and error is shown below.
Error: Check failed: InvalidRequestException: You can’t perform this operation on the secret because it was marked for deletion.
--- FAIL: TestAccAwsSecretsManagerSecretVersion_VersionStages (16.18s)
testing.go:599: Error destroying resource! WARNING: Dangling resources
may exist. The full state and error is shown below.
Error: Check failed: InvalidRequestException: You can’t perform this operation on the secret because it was marked for deletion.
```
Output from acceptance testing:
```
--- PASS: TestAccAwsSecretsManagerSecretVersion_BasicString (11.80s)
--- PASS: TestAccAwsSecretsManagerSecretVersion_Base64Binary (11.81s)
--- PASS: TestAccAwsSecretsManagerSecretVersion_VersionStages (25.33s)
```
bflad
added
the
service/secretsmanager
ghost
added
size/XS
nywilken
reviewed
Apr 10, 2019
| // InvalidRequestException: You can’t perform this operation on the secret because it was deleted. | ||
| if isAWSErr(err, secretsmanager.ErrCodeInvalidRequestException, "You can’t perform this operation on the secret because it was deleted") { | ||
| // InvalidRequestException: You can't create this secret because a secret with this name is already scheduled for deletion. | ||
| if isAWSErr(err, secretsmanager.ErrCodeInvalidRequestException, "scheduled for deletion") || isAWSErr(err, secretsmanager.ErrCodeInvalidRequestException, "was deleted") { |
There was a problem hiding this comment.
Did you encounter while running acceptance tests or was this documented in the SDK?
There was a problem hiding this comment.
Acceptance testing:
--- FAIL: TestAccAwsSecretsManagerSecret_RecoveryWindowInDays_Recreate (6.87s)
testing.go:538: Step 1 error: Error applying: 1 error occurred:
* aws_secretsmanager_secret.test: 1 error occurred:
* aws_secretsmanager_secret.test: error creating Secrets Manager Secret: InvalidRequestException: You can't create this secret because a secret with this name is already scheduled for deletion.
nywilken
approved these changes
Apr 10, 2019
bflad
deleted the
t-aws_secretsmanager_secret_version-InvalidRequestException
branch
bflad
added a commit
that referenced
this pull request
Apr 10, 2019
|
This has been released in version 2.6.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Community Note
It seems the Secrets Manager service now delineates the pending deletion state with different error messages. Presumably the old messages could still be returned depending on timing.
Previous output from acceptance testing:
Output from acceptance testing: