-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#8506 ability to import an existing lambda alias to terraform state #8513
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks so much, @richardjennings! 🚀
Output from acceptance testing:
--- PASS: TestAccAWSLambdaAlias_basic (34.51s)
--- PASS: TestAccAWSLambdaAlias_nameupdate (40.00s)
--- PASS: TestAccAWSLambdaAlias_routingconfig (45.76s)
@@ -117,6 +120,7 @@ func resourceAwsLambdaAliasRead(d *schema.ResourceData, meta interface{}) error | |||
d.Set("function_version", aliasConfiguration.FunctionVersion) | |||
d.Set("name", aliasConfiguration.Name) | |||
d.Set("arn", aliasConfiguration.AliasArn) | |||
d.SetId(*aliasConfiguration.AliasArn) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typically d.SetId()
should only be called during Create
and Importer
State
functions, however this is understandably a little more nuanced here since if we followed that rule here we would need the entire alias ARN passed into terraform import
or to make an additional API call in the import function which is less than ideal. I'm okay with merging this as-is for now to get this functionality in. 👍
This has been released in version 2.10.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
Community Note
Fixes #8506
Release note for CHANGELOG:
Output from acceptance testing: