Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws_eks_cluster: Increase create timeout to 30 mins #8909

Merged
merged 1 commit into from
Jun 10, 2019

Conversation

jen20
Copy link
Contributor

@jen20 jen20 commented Jun 7, 2019

It seems that as reported in #5165, an EKS cluster frequently takes more to actually bring up than the default create timeout allows for. While the timeout is configurable, the default should be sufficient to actually provision a cluster in most cases.

This commit increases the default timeout to 30 minutes.

Fixes #5165.

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Release note for CHANGELOG:

Increase default create timeout for `aws_eks_cluster` to 30 minutes.

@jen20 jen20 requested a review from bflad June 7, 2019 17:00
@ghost ghost added size/XS Managed by automation to categorize the size of a PR. service/eks Issues and PRs that pertain to the eks service. labels Jun 7, 2019
@bflad bflad added this to the v2.15.0 milestone Jun 7, 2019
@bflad bflad self-assigned this Jun 7, 2019
@bflad bflad added the waiting-response Maintainers are waiting on response from community or contributor. label Jun 7, 2019
It seems that as reported in #5165, an EKS cluster frequently takes more to
actually bring up than the default create timeout allows for. While the timeout
is configurable, the default should be sufficient to actually provision a
cluster in most cases.

This commit bumps the default timeout to 30 minutes.

Fixes #5165.
@jen20 jen20 force-pushed the jen20/eks-cluster-create-timeout branch from c712d66 to 59040e9 Compare June 8, 2019 04:08
@ghost ghost added the documentation Introduces or discusses updates to documentation. label Jun 8, 2019
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @jen20! 🚀

@bflad bflad merged commit a27ce74 into master Jun 10, 2019
@bflad bflad deleted the jen20/eks-cluster-create-timeout branch June 10, 2019 01:07
bflad added a commit that referenced this pull request Jun 10, 2019
@ghost
Copy link

ghost commented Nov 3, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Nov 3, 2019
@ghost ghost removed the waiting-response Maintainers are waiting on response from community or contributor. label Nov 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. service/eks Issues and PRs that pertain to the eks service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aws_eks_cluster tales longer to create than the timeout period
2 participants