Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Final retries for docdb cluster operations #8986

Merged
merged 1 commit into from
Jun 13, 2019
Merged

Final retries for docdb cluster operations #8986

merged 1 commit into from
Jun 13, 2019

Conversation

ryndaniels
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

References #7873

Release note for CHANGELOG:

BUG FIXES:
* resource/aws_docdb_cluster: Retries after timeout errors for docdb cluster operations

Output from acceptance testing:

$ make testacc TESTARGS="-run=TestAccAWSDocDBCluster"==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -parallel 20 -run=TestAccAWSDocDBCluster -timeout 120m
?       github.com/terraform-providers/terraform-provider-aws   [no test files]
=== RUN   TestAccAWSDocDBClusterInstance_basic
=== PAUSE TestAccAWSDocDBClusterInstance_basic
=== RUN   TestAccAWSDocDBClusterInstance_az
=== PAUSE TestAccAWSDocDBClusterInstance_az
=== RUN   TestAccAWSDocDBClusterInstance_namePrefix
=== PAUSE TestAccAWSDocDBClusterInstance_namePrefix
=== RUN   TestAccAWSDocDBClusterInstance_generatedName
=== PAUSE TestAccAWSDocDBClusterInstance_generatedName
=== RUN   TestAccAWSDocDBClusterInstance_kmsKey
=== PAUSE TestAccAWSDocDBClusterInstance_kmsKey
=== RUN   TestAccAWSDocDBClusterInstance_disappears
=== PAUSE TestAccAWSDocDBClusterInstance_disappears
=== RUN   TestAccAWSDocDBClusterParameterGroup_basic
=== PAUSE TestAccAWSDocDBClusterParameterGroup_basic
=== RUN   TestAccAWSDocDBClusterParameterGroup_namePrefix
=== PAUSE TestAccAWSDocDBClusterParameterGroup_namePrefix
=== RUN   TestAccAWSDocDBClusterParameterGroup_generatedName
=== PAUSE TestAccAWSDocDBClusterParameterGroup_generatedName
=== RUN   TestAccAWSDocDBClusterParameterGroup_Description
=== PAUSE TestAccAWSDocDBClusterParameterGroup_Description
=== RUN   TestAccAWSDocDBClusterParameterGroup_disappears
=== PAUSE TestAccAWSDocDBClusterParameterGroup_disappears
=== RUN   TestAccAWSDocDBClusterParameterGroup_Parameter
=== PAUSE TestAccAWSDocDBClusterParameterGroup_Parameter
=== RUN   TestAccAWSDocDBClusterParameterGroup_Tags
=== PAUSE TestAccAWSDocDBClusterParameterGroup_Tags
=== RUN   TestAccAWSDocDBClusterSnapshot_basic
=== PAUSE TestAccAWSDocDBClusterSnapshot_basic
=== RUN   TestAccAWSDocDBCluster_basic
=== PAUSE TestAccAWSDocDBCluster_basic
=== RUN   TestAccAWSDocDBCluster_namePrefix
=== PAUSE TestAccAWSDocDBCluster_namePrefix
=== RUN   TestAccAWSDocDBCluster_generatedName
=== PAUSE TestAccAWSDocDBCluster_generatedName
=== RUN   TestAccAWSDocDBCluster_takeFinalSnapshot
=== PAUSE TestAccAWSDocDBCluster_takeFinalSnapshot
=== RUN   TestAccAWSDocDBCluster_missingUserNameCausesError
=== PAUSE TestAccAWSDocDBCluster_missingUserNameCausesError
=== RUN   TestAccAWSDocDBCluster_updateTags
=== PAUSE TestAccAWSDocDBCluster_updateTags
=== RUN   TestAccAWSDocDBCluster_updateCloudwatchLogsExports
=== PAUSE TestAccAWSDocDBCluster_updateCloudwatchLogsExports
=== RUN   TestAccAWSDocDBCluster_kmsKey
=== PAUSE TestAccAWSDocDBCluster_kmsKey
=== RUN   TestAccAWSDocDBCluster_encrypted
=== PAUSE TestAccAWSDocDBCluster_encrypted
=== RUN   TestAccAWSDocDBCluster_backupsUpdate
=== PAUSE TestAccAWSDocDBCluster_backupsUpdate
=== RUN   TestAccAWSDocDBCluster_Port
=== PAUSE TestAccAWSDocDBCluster_Port
=== CONT  TestAccAWSDocDBClusterInstance_basic
=== CONT  TestAccAWSDocDBCluster_Port
=== CONT  TestAccAWSDocDBClusterParameterGroup_Parameter
=== CONT  TestAccAWSDocDBCluster_basic
=== CONT  TestAccAWSDocDBClusterParameterGroup_namePrefix
=== CONT  TestAccAWSDocDBClusterInstance_namePrefix
=== CONT  TestAccAWSDocDBClusterParameterGroup_basic
=== CONT  TestAccAWSDocDBClusterInstance_disappears
=== CONT  TestAccAWSDocDBClusterInstance_kmsKey
=== CONT  TestAccAWSDocDBClusterInstance_generatedName
=== CONT  TestAccAWSDocDBClusterParameterGroup_Tags
=== CONT  TestAccAWSDocDBClusterParameterGroup_Description
=== CONT  TestAccAWSDocDBCluster_updateTags
=== CONT  TestAccAWSDocDBCluster_missingUserNameCausesError
=== CONT  TestAccAWSDocDBCluster_takeFinalSnapshot
=== CONT  TestAccAWSDocDBCluster_generatedName
=== CONT  TestAccAWSDocDBCluster_namePrefix
=== CONT  TestAccAWSDocDBClusterParameterGroup_disappears
=== CONT  TestAccAWSDocDBClusterInstance_az
=== CONT  TestAccAWSDocDBClusterSnapshot_basic
=== CONT  TestAccAWSDocDBCluster_backupsUpdate
--- PASS: TestAccAWSDocDBCluster_missingUserNameCausesError (10.08s)
--- PASS: TestAccAWSDocDBClusterParameterGroup_disappears (21.85s)
=== CONT  TestAccAWSDocDBCluster_encrypted
--- PASS: TestAccAWSDocDBClusterParameterGroup_namePrefix (33.34s)
=== CONT  TestAccAWSDocDBCluster_kmsKey
--- PASS: TestAccAWSDocDBClusterParameterGroup_Description (33.39s)
=== CONT  TestAccAWSDocDBCluster_updateCloudwatchLogsExports
--- PASS: TestAccAWSDocDBClusterParameterGroup_basic (33.44s)
=== CONT  TestAccAWSDocDBClusterParameterGroup_generatedName
--- PASS: TestAccAWSDocDBClusterParameterGroup_Parameter (52.53s)
--- PASS: TestAccAWSDocDBClusterParameterGroup_generatedName (29.91s)
--- PASS: TestAccAWSDocDBClusterParameterGroup_Tags (75.16s)
--- PASS: TestAccAWSDocDBCluster_encrypted (121.67s)
--- PASS: TestAccAWSDocDBCluster_generatedName (166.94s)
--- PASS: TestAccAWSDocDBCluster_namePrefix (167.07s)
--- PASS: TestAccAWSDocDBCluster_basic (167.11s)
--- PASS: TestAccAWSDocDBCluster_takeFinalSnapshot (190.08s)
--- PASS: TestAccAWSDocDBCluster_updateTags (205.24s)
--- PASS: TestAccAWSDocDBCluster_backupsUpdate (202.10s)
--- PASS: TestAccAWSDocDBCluster_kmsKey (183.55s)
--- PASS: TestAccAWSDocDBCluster_updateCloudwatchLogsExports (190.83s)
--- PASS: TestAccAWSDocDBClusterSnapshot_basic (274.88s)
--- PASS: TestAccAWSDocDBCluster_Port (299.84s)
--- PASS: TestAccAWSDocDBClusterInstance_disappears (703.34s)
--- PASS: TestAccAWSDocDBClusterInstance_az (704.32s)
--- PASS: TestAccAWSDocDBClusterInstance_namePrefix (759.67s)
--- PASS: TestAccAWSDocDBClusterInstance_kmsKey (773.79s)
--- PASS: TestAccAWSDocDBClusterInstance_generatedName (796.45s)
--- PASS: TestAccAWSDocDBClusterInstance_basic (1371.85s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       1372.686s

@ghost ghost added the size/XS Managed by automation to categorize the size of a PR. label Jun 13, 2019
@ryndaniels ryndaniels added the bug Addresses a defect in current functionality. label Jun 13, 2019
@ryndaniels ryndaniels requested a review from bflad June 13, 2019 15:33
@github-actions github-actions bot added the service/docdb Issues and PRs that pertain to the docdb service. label Jun 13, 2019
@bflad bflad added this to the v2.15.0 milestone Jun 13, 2019
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀 Merging so we can release this today.

--- PASS: TestAccAWSDocDBCluster_missingUserNameCausesError (6.47s)
--- PASS: TestAccAWSDocDBClusterParameterGroup_disappears (11.91s)
--- PASS: TestAccAWSDocDBClusterParameterGroup_Description (12.44s)
--- PASS: TestAccAWSDocDBClusterParameterGroup_generatedName (12.66s)
--- PASS: TestAccAWSDocDBClusterParameterGroup_namePrefix (13.32s)
--- PASS: TestAccAWSDocDBClusterParameterGroup_basic (13.75s)
--- PASS: TestAccAWSDocDBClusterParameterGroup_Parameter (19.82s)
--- PASS: TestAccAWSDocDBClusterParameterGroup_Tags (26.20s)
--- PASS: TestAccAWSDocDBCluster_encrypted (111.72s)
--- PASS: TestAccAWSDocDBCluster_updateCloudwatchLogsExports (134.59s)
--- PASS: TestAccAWSDocDBCluster_generatedName (145.15s)
--- PASS: TestAccAWSDocDBCluster_basic (145.24s)
--- PASS: TestAccAWSDocDBCluster_namePrefix (145.20s)
--- PASS: TestAccAWSDocDBCluster_updateTags (179.80s)
--- PASS: TestAccAWSDocDBCluster_kmsKey (168.66s)
--- PASS: TestAccAWSDocDBClusterSnapshot_basic (183.15s)
--- PASS: TestAccAWSDocDBCluster_backupsUpdate (174.32s)
--- PASS: TestAccAWSDocDBCluster_takeFinalSnapshot (246.24s)
--- PASS: TestAccAWSDocDBCluster_Port (277.89s)
--- PASS: TestAccAWSDocDBClusterInstance_az (672.60s)
--- PASS: TestAccAWSDocDBClusterInstance_generatedName (704.69s)
--- PASS: TestAccAWSDocDBClusterInstance_disappears (706.81s)
--- PASS: TestAccAWSDocDBClusterInstance_namePrefix (765.79s)
--- PASS: TestAccAWSDocDBClusterInstance_kmsKey (833.68s)
--- PASS: TestAccAWSDocDBClusterInstance_basic (1437.34s)

@bflad bflad merged commit b7ee337 into master Jun 13, 2019
@bflad bflad deleted the rfd-retry-docdb branch June 13, 2019 20:41
bflad added a commit that referenced this pull request Jun 13, 2019
@ghost
Copy link

ghost commented Nov 3, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Nov 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/docdb Issues and PRs that pertain to the docdb service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants