Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for terraform import to resource backup_vault #9041

Merged
merged 3 commits into from
Jun 19, 2019

Conversation

programmer04
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Fixes #8821

Release note for CHANGELOG:

resource/backup_vault: Add support for terraform import

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAwsBackupVault*'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -parallel 20 -run=TestAccAwsBackupVault* -timeout 120m
?       github.com/terraform-providers/terraform-provider-aws   [no test files]
=== RUN   TestAccAwsBackupVault_basic
=== PAUSE TestAccAwsBackupVault_basic
=== RUN   TestAccAwsBackupVault_withKmsKey
=== PAUSE TestAccAwsBackupVault_withKmsKey
=== RUN   TestAccAwsBackupVault_withTags
=== PAUSE TestAccAwsBackupVault_withTags
=== CONT  TestAccAwsBackupVault_basic
=== CONT  TestAccAwsBackupVault_withTags
=== CONT  TestAccAwsBackupVault_withKmsKey
--- PASS: TestAccAwsBackupVault_basic (35.66s)
--- PASS: TestAccAwsBackupVault_withTags (73.89s)
--- PASS: TestAccAwsBackupVault_withKmsKey (75.44s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       75.500s

@ghost ghost added size/XS Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. labels Jun 18, 2019
@github-actions github-actions bot added the service/backup Issues and PRs that pertain to the backup service. label Jun 18, 2019
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @programmer04 👋 Thanks so much for this contribution. This is almost ready to go, it just needs testing added (that of course passes when added 😄 ). Please reach out if you have any questions or do not have time to implement this.

aws/resource_aws_backup_vault.go Show resolved Hide resolved
@bflad bflad added enhancement Requests to existing resources that expand the functionality or scope. waiting-response Maintainers are waiting on response from community or contributor. labels Jun 18, 2019
@bflad bflad self-assigned this Jun 18, 2019
@ghost ghost added size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. and removed size/XS Managed by automation to categorize the size of a PR. labels Jun 19, 2019
@bflad bflad removed the waiting-response Maintainers are waiting on response from community or contributor. label Jun 19, 2019
@bflad bflad self-requested a review June 19, 2019 14:13
@bflad bflad added this to the v2.16.0 milestone Jun 19, 2019
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, @programmer04, thanks! 🚀

Output from acceptance testing:

--- PASS: TestAccAwsBackupVault_basic (8.74s)
--- PASS: TestAccAwsBackupVault_withTags (18.43s)
--- PASS: TestAccAwsBackupVault_withKmsKey (28.11s)

@bflad bflad merged commit 0a69682 into hashicorp:master Jun 19, 2019
bflad added a commit that referenced this pull request Jun 19, 2019
@programmer04 programmer04 deleted the backup-vault-import branch June 20, 2019 09:13
@bflad
Copy link
Contributor

bflad commented Jun 20, 2019

This has been released in version 2.16.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ghost
Copy link

ghost commented Nov 3, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Nov 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/backup Issues and PRs that pertain to the backup service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support import on aws_backup_vault resource
2 participants