Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resource/api_gateway_domain_name: Add support for security_policy #9128

Merged
merged 1 commit into from
Jul 16, 2019
Merged

resource/api_gateway_domain_name: Add support for security_policy #9128

merged 1 commit into from
Jul 16, 2019

Conversation

stack72
Copy link
Contributor

@stack72 stack72 commented Jun 25, 2019

Fixes: #9100

@stack72 stack72 requested a review from a team June 25, 2019 12:13
@ghost ghost added size/XS Managed by automation to categorize the size of a PR. service/apigateway Issues and PRs that pertain to the apigateway service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. documentation Introduces or discusses updates to documentation. labels Jun 25, 2019
@bflad bflad added the enhancement Requests to existing resources that expand the functionality or scope. label Jun 26, 2019
@ewbankkit ewbankkit mentioned this pull request Jul 2, 2019
Closed
@damianh
Copy link

damianh commented Jul 9, 2019

Nice, was just looking for this. LGTM?

@AmillerSC
Copy link

@stack72 any ETA on when this PR can be merged? We are seeking this functionality as well.

Thanks

@stack72
Copy link
Contributor Author

stack72 commented Jul 11, 2019

@AmillerSC I’m just a community member - the merge is down to the Terraform team so we need to wait for them I’m afraid

@AmillerSC
Copy link

@stack72 Understood - appreciate your contribution. I found it odd this wasn't already possible because the documentation says "This resource just establishes ownership of and the TLS settings for a particular domain name."

@damianh
Copy link

damianh commented Jul 11, 2019

Yeah that statement in the docs confused me too

@bflad bflad self-assigned this Jul 11, 2019
@ewbankkit ewbankkit mentioned this pull request Jul 12, 2019
Closed
@bflad bflad added this to the v2.20.0 milestone Jul 16, 2019
bflad
bflad approved these changes Jul 16, 2019
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks, @stack72! 🚀 One minor note, moved the testing to its own acceptance test and test configuration in a followup commit. 👍

--- PASS: TestAccAWSAPIGatewayDomainName_SecurityPolicy (66.49s)
--- PASS: TestAccAWSAPIGatewayDomainName_RegionalCertificateArn (121.03s)

@bflad bflad merged commit 23e0717 into hashicorp:master Jul 16, 2019
bflad added a commit that referenced this pull request Jul 16, 2019
@bflad
Update CHANGELOG for #9128
f945137
@ghost
Copy link

ghost commented Nov 2, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Nov 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bflad bflad bflad approved these changes

Assignees

@bflad bflad

Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/apigateway Issues and PRs that pertain to the apigateway service. size/XS Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v2.20.0
Development

Successfully merging this pull request may close these issues.

Support configurable TLS Version for Custom Domains - AWS API Gateway
4 participants
@stack72 @damianh @AmillerSC @bflad