-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
r/aws_rds_cluster: Add TimeoutAction support #9374
Conversation
Also, please review my other PRs that have been open for quite a while. https://github.com/terraform-providers/terraform-provider-aws/pulls/stefansundin At least #7544 should be completely uncontroversial to merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, @stefansundin, thanks. 🚀
--- PASS: TestAccAWSRDSCluster_generatedName (103.44s)
--- PASS: TestAccAWSRDSCluster_basic (103.88s)
--- PASS: TestAccAWSRDSCluster_missingUserNameCausesError (3.53s)
--- PASS: TestAccAWSRDSCluster_BacktrackWindow (139.74s)
--- PASS: TestAccAWSRDSCluster_DbSubnetGroupName (141.19s)
--- PASS: TestAccAWSRDSCluster_ClusterIdentifierPrefix (147.35s)
--- PASS: TestAccAWSRDSCluster_importBasic (147.45s)
--- PASS: TestAccAWSRDSCluster_AvailabilityZones (147.81s)
--- PASS: TestAccAWSRDSCluster_takeFinalSnapshot (164.84s)
--- PASS: TestAccAWSRDSCluster_encrypted (108.58s)
--- PASS: TestAccAWSRDSCluster_Tags (153.91s)
--- PASS: TestAccAWSRDSCluster_updateIamRoles (134.59s)
--- PASS: TestAccAWSRDSCluster_kmsKey (147.74s)
--- PASS: TestAccAWSRDSCluster_EnabledCloudwatchLogsExports (189.46s)
--- PASS: TestAccAWSRDSCluster_backupsUpdate (153.19s)
--- PASS: TestAccAWSRDSCluster_copyTagsToSnapshot (190.39s)
--- PASS: TestAccAWSRDSCluster_iamAuth (108.21s)
--- PASS: TestAccAWSRDSCluster_EngineMode_Global (109.68s)
--- PASS: TestAccAWSRDSCluster_DeletionProtection (143.97s)
--- PASS: TestAccAWSRDSCluster_EngineMode_ParallelQuery (108.78s)
--- PASS: TestAccAWSRDSCluster_EngineVersion (130.75s)
--- PASS: TestAccAWSRDSCluster_GlobalClusterIdentifier (123.55s)
--- PASS: TestAccAWSRDSCluster_GlobalClusterIdentifier_Update (125.16s)
--- PASS: TestAccAWSRDSCluster_GlobalClusterIdentifier_Remove (129.30s)
--- PASS: TestAccAWSRDSCluster_GlobalClusterIdentifier_Add (133.29s)
--- PASS: TestAccAWSRDSClusterInstance_namePrefix (638.51s)
--- SKIP: TestAccAWSRDSCluster_SnapshotIdentifier_EngineMode_Serverless (0.00s)
--- PASS: TestAccAWSRDSClusterInstance_generatedName (645.12s)
--- PASS: TestAccAWSRDSClusterInstance_CopyTagsToSnapshot (658.66s)
--- PASS: TestAccAWSRDSClusterInstance_withInstanceEnhancedMonitor (685.63s)
--- PASS: TestAccAWSRDSCluster_Port (275.55s)
--- PASS: TestAccAWSRDSClusterInstance_disappears (730.06s)
--- PASS: TestAccAWSRDSClusterInstance_PubliclyAccessible (749.89s)
--- PASS: TestAccAWSRDSClusterInstance_az (750.71s)
--- PASS: TestAccAWSRDSClusterInstance_withInstancePerformanceInsights (794.59s)
--- PASS: TestAccAWSRDSClusterInstance_kmsKey (813.86s)
--- PASS: TestAccAWSRDSCluster_ScalingConfiguration (349.24s)
--- PASS: TestAccAWSRDSCluster_SnapshotIdentifier_EngineMode_ParallelQuery (347.09s)
--- PASS: TestAccAWSRDSCluster_SnapshotIdentifier (367.11s)
--- PASS: TestAccAWSRDSCluster_SnapshotIdentifier_EngineMode_Provisioned (347.19s)
--- PASS: TestAccAWSRDSCluster_SnapshotIdentifier_DeletionProtection (414.26s)
--- PASS: TestAccAWSRDSCluster_SnapshotIdentifier_EngineVersion_Different (347.37s)
--- PASS: TestAccAWSRDSCluster_SnapshotIdentifier_EngineVersion_Equal (367.67s)
--- PASS: TestAccAWSRDSCluster_SnapshotIdentifier_Tags (326.36s)
--- PASS: TestAccAWSRDSCluster_SnapshotIdentifier_PreferredMaintenanceWindow (367.64s)
--- PASS: TestAccAWSRDSCluster_SnapshotIdentifier_VpcSecurityGroupIds_Tags (338.43s)
--- PASS: TestAccAWSRDSCluster_SnapshotIdentifier_EncryptedRestore (341.13s)
--- PASS: TestAccAWSRDSCluster_SnapshotIdentifier_VpcSecurityGroupIds (388.86s)
--- PASS: TestAccAWSRDSClusterEndpoint_basic (1164.50s)
--- PASS: TestAccAWSRDSClusterInstance_basic (1410.15s)
--- PASS: TestAccAWSRDSCluster_EngineVersionWithPrimaryInstance (1118.40s)
--- PASS: TestAccAWSRDSCluster_EncryptedCrossRegionReplication (1530.99s)
The enhancement to the For further feature requests or bug reports with this resource, please create a new GitHub issue following the template for triage. Thanks! |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
Community Note
Fixes #8929
Release note for CHANGELOG:
Output from acceptance testing: