Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

data-source/aws_route53_zone: add linked service attributes #9390

Merged
merged 1 commit into from
Jul 18, 2019
Merged

data-source/aws_route53_zone: add linked service attributes #9390

merged 1 commit into from
Jul 18, 2019

Conversation

jstewmon
Copy link
Contributor

  • updated test error strings to better reflect actual vs expected
  • fixed name_servers check to test the data source, not the resource
  • renamed the resource attributes variable and added a data source
    attributes varialbe to improve readability

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Release note for CHANGELOG:

data-source/aws_route53_zone: new attributes `linked_service_principal` and `linked_service_description`

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccDataSourceAwsRoute53Zone'
=== RUN   TestAccDataSourceAwsRoute53Zone
=== PAUSE TestAccDataSourceAwsRoute53Zone
=== CONT  TestAccDataSourceAwsRoute53Zone
--- PASS: TestAccDataSourceAwsRoute53Zone (128.46s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	128.504s
...

@jstewmon jstewmon requested a review from a team July 17, 2019 18:48
@ghost ghost added size/M Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/route53 Issues and PRs that pertain to the route53 service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Jul 17, 2019
bflad
bflad suggested changes Jul 18, 2019
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @jstewmon 👋 Thank you for submitting this. I left an initial review below -- please reach out if you have any questions or do not have time to implement the feedback items. 👍

aws/data_source_aws_route53_zone.go Outdated Show resolved Hide resolved
aws/data_source_aws_route53_zone.go Outdated Show resolved Hide resolved
aws/data_source_aws_route53_zone_test.go Outdated Show resolved Hide resolved
aws/data_source_aws_route53_zone_test.go Outdated Show resolved Hide resolved
@bflad bflad self-assigned this Jul 18, 2019
@bflad bflad added enhancement Requests to existing resources that expand the functionality or scope. waiting-response Maintainers are waiting on response from community or contributor. labels Jul 18, 2019
@jstewmon jstewmon force-pushed the route53-zone-linked-service branch from 43b2660 to 93f1cc8 Compare July 18, 2019 19:51
@jstewmon
data-source/aws_route53_zone: add linked service attributes
93f1cc8 
- updated test checks to leverage to test helpers
- updated the tf config to use explicit argument indexes
@jstewmon
Copy link
Contributor Author

@bflad thanks for the excellent feedback. I've incorporated your suggestions and completely replaced the old test check function with the resource helpers.

@ghost ghost removed the waiting-response Maintainers are waiting on response from community or contributor. label Jul 18, 2019
bflad
bflad approved these changes Jul 18, 2019
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These updates are great, thanks so much, @jstewmon 🚀

--- PASS: TestAccDataSourceAwsRoute53Zone (121.88s)

aws/data_source_aws_route53_zone.go
@@ -32,12 +32,10 @@ func dataSourceAwsRoute53Zone() *schema.Resource {
},
"comment": {
Type: schema.TypeString,
Optional: true,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙇 thank you

aws/data_source_aws_route53_zone_test.go
// rsName for the name of the created resource
// dsName for the name of the created data source
// zName for the name of the domain
func testAccDataSourceAwsRoute53ZoneCheck(rsName, dsName, zName string) resource.TestCheckFunc {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️ thank you!

@bflad bflad added this to the v2.20.0 milestone Jul 18, 2019
@bflad bflad merged commit 85abeab into hashicorp:master Jul 18, 2019
bflad added a commit that referenced this pull request Jul 18, 2019
@bflad
Update CHANGELOG for #9390
5ed9388
@jstewmon jstewmon deleted the route53-zone-linked-service branch July 18, 2019 22:12
@nywilken
Copy link
Contributor

The enhancement to the aws_route53_zone data source, has been released in version 2.20.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this resource, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Nov 2, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Nov 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bflad bflad bflad approved these changes

Assignees

@bflad bflad

Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/route53 Issues and PRs that pertain to the route53 service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v2.20.0
Development

Successfully merging this pull request may close these issues.
3 participants
@jstewmon @nywilken @bflad