Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Final retry after timeout deleting customer gateway #9421

Merged
merged 1 commit into from
Jul 24, 2019

Conversation

ryndaniels
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Relates #7873

Release note for CHANGELOG:

BUG FIXES
* aws/customer_gateway: Final retry after timeout deleting customer gateway

Output from acceptance testing:

$ make testacc TESTARGS="-run=TestAccAWSCustomerGateway"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -parallel 20 -run=TestAccAWSCustomerGateway -timeout 120m
?       github.com/terraform-providers/terraform-provider-aws   [no test files]
=== RUN   TestAccAWSCustomerGatewayDataSource_Filter
=== PAUSE TestAccAWSCustomerGatewayDataSource_Filter
=== RUN   TestAccAWSCustomerGatewayDataSource_ID
=== PAUSE TestAccAWSCustomerGatewayDataSource_ID
=== RUN   TestAccAWSCustomerGateway_importBasic
=== PAUSE TestAccAWSCustomerGateway_importBasic
=== RUN   TestAccAWSCustomerGateway_basic
=== PAUSE TestAccAWSCustomerGateway_basic
=== RUN   TestAccAWSCustomerGateway_similarAlreadyExists
=== PAUSE TestAccAWSCustomerGateway_similarAlreadyExists
=== RUN   TestAccAWSCustomerGateway_disappears
=== PAUSE TestAccAWSCustomerGateway_disappears
=== CONT  TestAccAWSCustomerGatewayDataSource_Filter
=== CONT  TestAccAWSCustomerGateway_disappears
=== CONT  TestAccAWSCustomerGatewayDataSource_ID
=== CONT  TestAccAWSCustomerGateway_similarAlreadyExists
=== CONT  TestAccAWSCustomerGateway_importBasic
=== CONT  TestAccAWSCustomerGateway_basic
--- PASS: TestAccAWSCustomerGateway_disappears (35.03s)
--- PASS: TestAccAWSCustomerGateway_importBasic (38.69s)
--- PASS: TestAccAWSCustomerGatewayDataSource_ID (41.36s)
--- PASS: TestAccAWSCustomerGatewayDataSource_Filter (42.86s)
--- PASS: TestAccAWSCustomerGateway_similarAlreadyExists (44.93s)
--- PASS: TestAccAWSCustomerGateway_basic (84.13s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       85.243s

@ryndaniels ryndaniels requested a review from a team July 19, 2019 16:09
@ghost ghost added size/S Managed by automation to categorize the size of a PR. service/ec2 Issues and PRs that pertain to the ec2 service. labels Jul 19, 2019
@bflad bflad added the bug Addresses a defect in current functionality. label Jul 23, 2019
@bflad bflad added this to the v2.21.0 milestone Jul 23, 2019
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

--- PASS: TestAccAWSCustomerGateway_disappears (18.00s)
--- PASS: TestAccAWSCustomerGateway_importBasic (19.49s)
--- PASS: TestAccAWSCustomerGatewayDataSource_ID (20.03s)
--- PASS: TestAccAWSCustomerGatewayDataSource_Filter (20.18s)
--- PASS: TestAccAWSCustomerGateway_similarAlreadyExists (21.55s)
--- PASS: TestAccAWSCustomerGateway_basic (39.24s)

@ryndaniels ryndaniels merged commit baf2034 into master Jul 24, 2019
@ryndaniels ryndaniels deleted the rfd-retry-custgw branch July 24, 2019 09:53
@ryndaniels ryndaniels restored the rfd-retry-custgw branch July 24, 2019 10:05
@ryndaniels ryndaniels deleted the rfd-retry-custgw branch July 24, 2019 13:14
@bflad
Copy link
Contributor

bflad commented Jul 26, 2019

This has been released in version 2.21.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests, documentation updates, or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Nov 2, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Nov 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/ec2 Issues and PRs that pertain to the ec2 service. size/S Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants