Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add WAF Regional IP set data source #9484

Merged
merged 2 commits into from
Jul 25, 2019
Merged

Conversation

ryndaniels
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Relates #2654

Release note for CHANGELOG:

* **New Data Source** `aws_wafregional_ipset`

Output from acceptance testing:

$ make testacc TESTARGS="-run=TestAccDataSourceAwsWafRegionalIPSet"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -parallel 20 -run=TestAccDataSourceAwsWafRegionalIPSet -timeout 120m
?       github.com/terraform-providers/terraform-provider-aws   [no test files]
=== RUN   TestAccDataSourceAwsWafRegionalIPSet_Basic
=== PAUSE TestAccDataSourceAwsWafRegionalIPSet_Basic
=== CONT  TestAccDataSourceAwsWafRegionalIPSet_Basic
--- PASS: TestAccDataSourceAwsWafRegionalIPSet_Basic (38.33s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       44.963s

Local screenshot of docs:
Screenshot 2019-07-24 at 17 23 48

@ryndaniels ryndaniels added the new-data-source Introduces a new data source. label Jul 24, 2019
@ryndaniels ryndaniels requested review from bflad and a team July 24, 2019 15:45
@ghost ghost added size/M Managed by automation to categorize the size of a PR. provider Pertains to the provider itself, rather than any interaction with AWS. service/waf Issues and PRs that pertain to the waf service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. documentation Introduces or discusses updates to documentation. labels Jul 24, 2019
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two nitpicks, but otherwise looks fantab. 🎉

--- PASS: TestAccDataSourceAwsWafRegionalIPSet_Basic (18.65s)

aws/data_source_aws_wafregional_ipset_test.go Outdated Show resolved Hide resolved
aws/data_source_aws_wafregional_ipset_test.go Show resolved Hide resolved
@ryndaniels ryndaniels force-pushed the rfd-wafregional-ipset branch from 695effc to 51aa713 Compare July 24, 2019 17:23
@ryndaniels ryndaniels merged commit e48ade3 into master Jul 25, 2019
@ryndaniels ryndaniels deleted the rfd-wafregional-ipset branch July 25, 2019 08:07
@ryndaniels ryndaniels added this to the v2.21.0 milestone Jul 25, 2019
@bflad
Copy link
Contributor

bflad commented Jul 26, 2019

This has been released in version 2.21.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests, documentation updates, or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Nov 2, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Nov 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. new-data-source Introduces a new data source. provider Pertains to the provider itself, rather than any interaction with AWS. service/waf Issues and PRs that pertain to the waf service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants