Aws vpc peering connections #9491

tmccombs · 2019-07-25T03:53:16Z

Community Note

Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Closes #6350
Relates to #6351

This is built on top of #6351, but I resolved the merge conflict and cleaned it up a little bit. If you want to pull these changes into the exiting PR, that's fine with me.

Release note for CHANGELOG:

- Add aws_vpc_peering_connections
list all peering connections using filters, returning ids.
Useful when trying to build route tables between vpcs with multiple
peering connections managed in different state files.

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccDataSourceAwsVpcPeeringConnections_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -parallel 20 -run=TestAccDataSourceAwsVpcPeeringConnections_basic -timeout 120m
?       github.com/terraform-providers/terraform-provider-aws   [no test files]
=== RUN   TestAccDataSourceAwsVpcPeeringConnections_basic
--- PASS: TestAccDataSourceAwsVpcPeeringConnections_basic (41.68s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       41.713s

ewbankkit · 2020-03-20T18:39:35Z

@tmccombs Thanks for this.
After rebasing to the current master there were a couple of minor compilation errors but after fixing those I verified the acceptance test:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccDataSourceAwsVpcPeeringConnections_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -count 1 -parallel 20 -run=TestAccDataSourceAwsVpcPeeringConnections_ -timeout 120m
=== RUN   TestAccDataSourceAwsVpcPeeringConnections_basic
--- PASS: TestAccDataSourceAwsVpcPeeringConnections_basic (57.08s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	57.108s

If you have time you could rebase from https://github.com/ewbankkit/terraform-provider-aws/tree/issue-6350, else I can create another PR including the minor changes.

tmccombs · 2020-03-21T05:25:31Z

If you have time you could rebase from https://github.com/ewbankkit/terraform-provider-aws/tree/issue-6350

done

ewbankkit · 2020-03-21T21:18:08Z

@tmccombs Thanks.
Validated acceptance tests:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccDataSourceAwsVpcPeeringConnections_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -count 1 -parallel 20 -run=TestAccDataSourceAwsVpcPeeringConnections_ -timeout 120m
=== RUN   TestAccDataSourceAwsVpcPeeringConnections_basic
--- PASS: TestAccDataSourceAwsVpcPeeringConnections_basic (40.73s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	40.775s

Could you take a look at the Travis website linting errors?

pgporada · 2020-07-28T19:26:04Z

Hi, we could really use this feature. Would someone mind fixing the conflict so it can eventually be merged?

teamterraform · 2020-08-18T20:01:47Z

Notification of Recent and Upcoming Changes to Contributions

Thank you for this contribution! There have been a few recent development changes that affect this pull request. We apologize for the inconvenience, especially if there have been long review delays up until now. Please note that this is automated message from an unmonitored account. See the FAQ for additional information on the maintainer team and review prioritization.

If you are unable to complete these updates, please leave a comment for the community and maintainers so someone can potentially continue the work. The maintainers will encourage other contributors to use the existing contribution as the base for additional changes as appropriate. Otherwise, contributions that do not receive updated code or comments from the original contributor may be closed in the future so the maintainers can focus on active items.

For the most up to date information about Terraform AWS Provider development, see the Contributing Guide. Additional technical debt changes can be tracked with the technical-debt label on issues.

As part of updating a pull request with these changes, the most current unit testing and linting will run. These may report issues that were not previously reported.

Action Required: Terraform 0.12 Syntax

Reference: #8950
Reference: #14417

Version 3 and later of the Terraform AWS Provider, which all existing contributions would potentially be added, only supports Terraform 0.12 and later. Certain syntax elements of Terraform 0.11 and earlier show deprecation warnings during runs with Terraform 0.12. Documentation and test configurations, such as those including deprecated string interpolations (some_attribute = "${aws_service_thing.example.id}") should be updated to the newer syntax (some_attribute = aws_service_thing.example.id). Contribution testing will automatically fail on older syntax in the near future. Please see the referenced issues for additional information.

Action Required: Terraform Plugin SDK Version 2

Reference: #14551

The Terraform AWS Provider has been upgraded to the latest version of the Terraform Plugin SDK. Generally, most changes to contributions should only involve updating Go import paths in source code files. Please see the referenced issue for additional information.

Removal of website/aws.erb File

Reference: #14712

Any changes to the website/aws.erb file are no longer necessary and should be removed from this contribution to prevent merge issues in the near future when the file is removed from the repository. Please see the referenced issue for additional information.

Upcoming Change of Git Branch Naming

Reference: #14292

Development environments will need their upstream Git branch updated from master to main in the near future. Please see the referenced issue for additional information and scheduling.

Upcoming Change of GitHub Organization

Reference: #14715

This repository will be migrating from https://github.com/terraform-providers/terraform-provider-aws to https://github.com/hashicorp/terraform-provider-aws. No practitioner or developer action is anticipated and most GitHub functionality will automatically redirect to the new location. Go import paths including terraform-providers can remain for now. Please see the referenced issue for additional information and scheduling.

list all peering connections using filters, returning ids, cidr_blocks and peer_cidr_blocks useful when trying to build route tables between vpcs with multiple peering connections managed in different state files

…les.

bflad

Hi @tmccombs 👋 Thank you for updating this pull request. Please note there is one feedback item that will still be pending, but the others should be addressable. 👍

bflad · 2020-08-19T12:42:08Z

aws/data_source_aws_vpc_peering_connections.go

+		ids = append(ids, aws.StringValue(pcx.VpcPeeringConnectionId))
+	}
+
+	d.SetId(resource.UniqueId())


Please note that using an unstable ID causes issues in Terraform CLI 0.13.0 (#14579) and we will add linting for this shortly, although we haven't quite determined what solution we would prefer. Hopefully more soon.

hmm, ok. should I leave it as is for now? Or should I change it to something else (although I'm not sure what)?

It looks like 0.13.1 might have mitigated this issue in 0.13 for now, so while its less than ideal we can include this as-is until we figure out long term plans rather than leaving this PR linger even longer. 👍

aws/data_source_aws_vpc_peering_connections_test.go

Code review suggestions for vpc_peering_connections Co-authored-by: Brian Flad <bflad417@gmail.com>

bflad

Thanks so much, @tmccombs 🚀

Output from acceptance testing:

--- PASS: TestAccDataSourceAwsVpcPeeringConnections_basic (14.21s)

ghost · 2020-09-03T19:32:33Z

This has been released in version 3.5.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

ghost · 2020-10-02T17:10:19Z

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

tmccombs requested a review from a team July 25, 2019 03:53

tmccombs force-pushed the aws_vpc_peering_connections branch from f828ff4 to 42efa80 Compare July 25, 2019 03:53

bflad added the new-data-source Introduces a new data source. label Jul 31, 2019

tmccombs force-pushed the aws_vpc_peering_connections branch 2 times, most recently from 2d0f4fa to 0450154 Compare March 21, 2020 05:24

anGie44 force-pushed the master branch from 6c6566f to 081bf57 Compare June 29, 2020 16:15

tmccombs force-pushed the aws_vpc_peering_connections branch from d50c8da to f43bee1 Compare July 29, 2020 06:22

ewbankkit mentioned this pull request Aug 3, 2020

adding aws_vpc_peering_connections #6351

Closed

Mark O'Shea and others added 5 commits August 18, 2020 22:59

adding aws_vpc_peering_connections

66b8991

list all peering connections using filters, returning ids, cidr_blocks and peer_cidr_blocks useful when trying to build route tables between vpcs with multiple peering connections managed in different state files

Clean up aws_vpn_peering_connections a little bit

0520ce6

d/aws_vpc_peering_connections: Fix compilation errors after rebase.

b9ef8c6

Fix vpc_peering_connections website lint

bbb3228

Use terraform 0.12 syntax for vpc_peering_connections tests and examp…

ab895d5

…les.

tmccombs force-pushed the aws_vpc_peering_connections branch from f43bee1 to ab895d5 Compare August 19, 2020 05:06

tmccombs added 2 commits August 18, 2020 23:24

Update aws_vpc_peering_connections to use terraform plugin sdk v2

d82b90a

Fix frontmatter for tfproviderdocs vpc_peering_connections

9e2d938

bflad suggested changes Aug 19, 2020

View reviewed changes

bflad self-assigned this Aug 19, 2020

tmccombs and others added 2 commits August 19, 2020 09:28

Apply suggestions from code review

210619a

Code review suggestions for vpc_peering_connections Co-authored-by: Brian Flad <bflad417@gmail.com>

Fix inconcsistent use of tabs

7e853f7

bflad added this to the v3.5.0 milestone Sep 1, 2020

bflad approved these changes Sep 1, 2020

View reviewed changes

bflad merged commit 30620bc into hashicorp:master Sep 1, 2020

bflad added a commit that referenced this pull request Sep 1, 2020

Update CHANGELOG for #9491

b8c327a

ghost locked as resolved and limited conversation to collaborators Oct 2, 2020

tmccombs deleted the aws_vpc_peering_connections branch October 3, 2020 02:59

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Aws vpc peering connections #9491

Aws vpc peering connections #9491

tmccombs commented Jul 25, 2019

ewbankkit commented Mar 20, 2020

tmccombs commented Mar 21, 2020

ewbankkit commented Mar 21, 2020 •

edited

Loading

pgporada commented Jul 28, 2020

teamterraform commented Aug 18, 2020

bflad left a comment

bflad Aug 19, 2020

tmccombs Aug 19, 2020

bflad Sep 1, 2020

bflad left a comment

ghost commented Sep 3, 2020

ghost commented Oct 2, 2020

Aws vpc peering connections #9491

Aws vpc peering connections #9491

Conversation

tmccombs commented Jul 25, 2019

Community Note

ewbankkit commented Mar 20, 2020

tmccombs commented Mar 21, 2020

ewbankkit commented Mar 21, 2020 • edited Loading

pgporada commented Jul 28, 2020

teamterraform commented Aug 18, 2020

Notification of Recent and Upcoming Changes to Contributions

Action Required: Terraform 0.12 Syntax

Action Required: Terraform Plugin SDK Version 2

Removal of website/aws.erb File

Upcoming Change of Git Branch Naming

Upcoming Change of GitHub Organization

bflad left a comment

Choose a reason for hiding this comment

bflad Aug 19, 2020

Choose a reason for hiding this comment

tmccombs Aug 19, 2020

Choose a reason for hiding this comment

bflad Sep 1, 2020

Choose a reason for hiding this comment

bflad left a comment

Choose a reason for hiding this comment

ghost commented Sep 3, 2020

ghost commented Oct 2, 2020

ewbankkit commented Mar 21, 2020 •

edited

Loading