Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/elastic_beanstalk_application_version: Scope labels to application #956

Merged
merged 1 commit into from
Jun 27, 2017

Conversation

radeksimko
Copy link
Member

This is to prevent issues mentioned in #954 by scoping the version lookup to the given application name.

Test plan

make testacc TEST=./aws TESTARGS='-run=TestAccAWSBeanstalkApp'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -run=TestAccAWSBeanstalk -timeout 120m
=== RUN   TestAccAWSBeanstalkApp_basic
--- PASS: TestAccAWSBeanstalkApp_basic (49.85s)
=== RUN   TestAccAWSBeanstalkAppVersion_basic
--- PASS: TestAccAWSBeanstalkAppVersion_basic (84.59s)
=== RUN   TestAccAWSBeanstalkAppVersion_duplicateLabels
--- PASS: TestAccAWSBeanstalkAppVersion_duplicateLabels (116.77s)

@radeksimko radeksimko added the bug Addresses a defect in current functionality. label Jun 23, 2017
Copy link
Contributor

@stack72 stack72 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - the description was confusing for a little bit

Confirmed in slack to be:

it’s to allow duplicates _across_ applications
in other words it’s allowing you to scope the namespace to an application

@radeksimko radeksimko changed the title r/elastic_beanstalk_application_version: Allow duplicate labels r/elastic_beanstalk_application_version: Scope labels to application Jun 27, 2017
@radeksimko radeksimko merged commit b70c1bb into master Jun 27, 2017
@radeksimko radeksimko deleted the b-aws-beanstalk-duplicate-labels branch June 27, 2017 08:05
@ghost
Copy link

ghost commented Apr 12, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants