Final retries after timeouts for EBS snapshot resources

[ryndaniels]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Relates #7873

Release note for CHANGELOG:

BUG FIXES:
* resource/aws_ebs_snapshot: Final retries after timeouts creating, deleting or waiting for available EBS snapshots
* resource/aws_ebs_snapshot_copy: Final retry after timeout deleting EBS snapshot copies

Output from acceptance testing:

$ make testacc TESTARGS="-run=TestAccAWSEBSSnapshot"      
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -parallel 20 -run=TestAccAWSEBSSnapshot -timeout 120m
?       github.com/terraform-providers/terraform-provider-aws   [no test files]
=== RUN   TestAccAWSEBSSnapshot_basic
=== PAUSE TestAccAWSEBSSnapshot_basic
=== RUN   TestAccAWSEBSSnapshot_withDescription
=== PAUSE TestAccAWSEBSSnapshot_withDescription
=== RUN   TestAccAWSEBSSnapshot_withKms
=== PAUSE TestAccAWSEBSSnapshot_withKms
=== CONT  TestAccAWSEBSSnapshot_basic
=== CONT  TestAccAWSEBSSnapshot_withKms
=== CONT  TestAccAWSEBSSnapshot_withDescription
--- PASS: TestAccAWSEBSSnapshot_withDescription (61.17s)
--- PASS: TestAccAWSEBSSnapshot_basic (68.95s)
--- PASS: TestAccAWSEBSSnapshot_withKms (100.38s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       101.511s

make testacc TESTARGS="-run=TestAccAWSEbsSnapshotCopy"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -parallel 20 -run=TestAccAWSEbsSnapshotCopy -timeout 120m
?       github.com/terraform-providers/terraform-provider-aws   [no test files]
=== RUN   TestAccAWSEbsSnapshotCopy_basic
=== PAUSE TestAccAWSEbsSnapshotCopy_basic
=== RUN   TestAccAWSEbsSnapshotCopy_withDescription
=== PAUSE TestAccAWSEbsSnapshotCopy_withDescription
=== RUN   TestAccAWSEbsSnapshotCopy_withRegions
=== PAUSE TestAccAWSEbsSnapshotCopy_withRegions
=== RUN   TestAccAWSEbsSnapshotCopy_withKms
=== PAUSE TestAccAWSEbsSnapshotCopy_withKms
=== RUN   TestAccAWSEbsSnapshotCopy_disappears
=== PAUSE TestAccAWSEbsSnapshotCopy_disappears
=== CONT  TestAccAWSEbsSnapshotCopy_basic
=== CONT  TestAccAWSEbsSnapshotCopy_withKms
=== CONT  TestAccAWSEbsSnapshotCopy_withDescription
=== CONT  TestAccAWSEbsSnapshotCopy_withRegions
=== CONT  TestAccAWSEbsSnapshotCopy_disappears
--- PASS: TestAccAWSEbsSnapshotCopy_withRegions (61.00s)
--- PASS: TestAccAWSEbsSnapshotCopy_disappears (62.40s)
--- PASS: TestAccAWSEbsSnapshotCopy_withDescription (63.40s)
--- PASS: TestAccAWSEbsSnapshotCopy_basic (63.46s)
--- PASS: TestAccAWSEbsSnapshotCopy_withKms (107.92s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       109.143s

[bflad]

LGTM 🚀

--- PASS: TestAccAWSEbsSnapshotCopy_basic (49.74s)
--- PASS: TestAccAWSEbsSnapshotCopy_disappears (50.26s)
--- PASS: TestAccAWSEbsSnapshotCopy_withDescription (51.24s)
--- PASS: TestAccAWSEBSSnapshot_withDescription (51.80s)
--- PASS: TestAccAWSEbsSnapshotCopy_withRegions (55.34s)
--- PASS: TestAccAWSEBSSnapshot_withKms (55.44s)
--- PASS: TestAccAWSEbsSnapshotCopy_withKms (68.74s)
--- PASS: TestAccAWSEBSSnapshot_basic (86.46s)

[ghost]

This has been released in version 2.24.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!