Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add BGP related information on aws_vpn_connection #973

Merged
merged 1 commit into from
Jun 27, 2017
Merged

Add BGP related information on aws_vpn_connection #973

merged 1 commit into from
Jun 27, 2017

Conversation

nati
Copy link
Contributor

@nati nati commented Jun 26, 2017

In this commit, we add tunnel1_bgp_asn, tunnel1_bgp_holdtime,
tunnel2_bgp_asn and tunnel2_bgp_hold time for aws_vpn_connection.
These values are needed to automate dynamic bgp vpn configuraion for
multi cloud provider such as interconnecting GCP and AWS.

In this commit, we add tunnel1_bgp_asn, tunnel1_bgp_holdtime,
 tunnel2_bgp_asn and tunnel2_bgp_hold time for aws_vpn_connection.
These values are needed to automate dynamic bgp vpn configuraion for
multi cloud provider such as interconnecting GCP and AWS.
@stack72 stack72 added the enhancement Requests to existing resources that expand the functionality or scope. label Jun 27, 2017
@stack72 stack72 self-requested a review June 27, 2017 14:04
@stack72 stack72 self-assigned this Jun 27, 2017
@stack72
Copy link
Contributor

stack72 commented Jun 27, 2017

Hi @nati

Thanks for the work here - this LGTM

% make testacc TEST=./aws TESTARGS='-run=TestAccAWSVpnConnection_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -run=TestAccAWSVpnConnection_ -timeout 120m
=== RUN   TestAccAWSVpnConnection_importBasic
--- PASS: TestAccAWSVpnConnection_importBasic (280.69s)
=== RUN   TestAccAWSVpnConnection_basic
--- PASS: TestAccAWSVpnConnection_basic (313.86s)
=== RUN   TestAccAWSVpnConnection_withoutStaticRoutes
--- PASS: TestAccAWSVpnConnection_withoutStaticRoutes (222.00s)
=== RUN   TestAccAWSVpnConnection_disappears
--- PASS: TestAccAWSVpnConnection_disappears (166.66s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	983.234s

Paul

@ghost
Copy link

ghost commented Apr 12, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants