Final retries for SQS resources

[ryndaniels]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Relates #7873

Release note for CHANGELOG:

BUG FIXES
* resource/aws_sqs_queue: Final retry after timeout creating queue
* resource/aws_sqs_queue_policy: Final retru after timeout updating queue policy

Output from acceptance testing:

$ make testacc TESTARGS="-run=TestAccAWSSQSQueue"      
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -parallel 20 -run=TestAccAWSSQSQueue -timeout 120m
?       github.com/terraform-providers/terraform-provider-aws   [no test files]
=== RUN   TestAccAWSSQSQueuePolicy_basic
=== PAUSE TestAccAWSSQSQueuePolicy_basic
=== RUN   TestAccAWSSQSQueuePolicy_import
=== PAUSE TestAccAWSSQSQueuePolicy_import
=== RUN   TestAccAWSSQSQueue_basic
=== PAUSE TestAccAWSSQSQueue_basic
=== RUN   TestAccAWSSQSQueue_tags
=== PAUSE TestAccAWSSQSQueue_tags
=== RUN   TestAccAWSSQSQueue_namePrefix
=== PAUSE TestAccAWSSQSQueue_namePrefix
=== RUN   TestAccAWSSQSQueue_namePrefix_fifo
=== PAUSE TestAccAWSSQSQueue_namePrefix_fifo
=== RUN   TestAccAWSSQSQueue_policy
=== PAUSE TestAccAWSSQSQueue_policy
=== RUN   TestAccAWSSQSQueue_queueDeletedRecently
=== PAUSE TestAccAWSSQSQueue_queueDeletedRecently
=== RUN   TestAccAWSSQSQueue_redrivePolicy
=== PAUSE TestAccAWSSQSQueue_redrivePolicy
=== RUN   TestAccAWSSQSQueue_Policybasic
=== PAUSE TestAccAWSSQSQueue_Policybasic
=== RUN   TestAccAWSSQSQueue_FIFO
=== PAUSE TestAccAWSSQSQueue_FIFO
=== RUN   TestAccAWSSQSQueue_FIFOExpectNameError
=== PAUSE TestAccAWSSQSQueue_FIFOExpectNameError
=== RUN   TestAccAWSSQSQueue_FIFOWithContentBasedDeduplication
=== PAUSE TestAccAWSSQSQueue_FIFOWithContentBasedDeduplication
=== RUN   TestAccAWSSQSQueue_ExpectContentBasedDeduplicationError
=== PAUSE TestAccAWSSQSQueue_ExpectContentBasedDeduplicationError
=== RUN   TestAccAWSSQSQueue_Encryption
=== PAUSE TestAccAWSSQSQueue_Encryption
=== CONT  TestAccAWSSQSQueuePolicy_basic
=== CONT  TestAccAWSSQSQueue_queueDeletedRecently
=== CONT  TestAccAWSSQSQueue_namePrefix
=== CONT  TestAccAWSSQSQueue_redrivePolicy
=== CONT  TestAccAWSSQSQueue_FIFOExpectNameError
=== CONT  TestAccAWSSQSQueue_FIFO
=== CONT  TestAccAWSSQSQueue_FIFOWithContentBasedDeduplication
=== CONT  TestAccAWSSQSQueue_Encryption
=== CONT  TestAccAWSSQSQueue_Policybasic
=== CONT  TestAccAWSSQSQueue_ExpectContentBasedDeduplicationError
=== CONT  TestAccAWSSQSQueue_policy
=== CONT  TestAccAWSSQSQueue_basic
=== CONT  TestAccAWSSQSQueue_namePrefix_fifo
=== CONT  TestAccAWSSQSQueue_tags
=== CONT  TestAccAWSSQSQueuePolicy_import
--- PASS: TestAccAWSSQSQueue_ExpectContentBasedDeduplicationError (10.58s)
--- PASS: TestAccAWSSQSQueue_FIFOExpectNameError (10.64s)
--- PASS: TestAccAWSSQSQueue_FIFOWithContentBasedDeduplication (31.60s)
--- PASS: TestAccAWSSQSQueue_namePrefix (31.67s)
--- PASS: TestAccAWSSQSQueue_namePrefix_fifo (31.83s)
--- PASS: TestAccAWSSQSQueue_FIFO (31.91s)
--- PASS: TestAccAWSSQSQueue_Encryption (31.99s)
--- PASS: TestAccAWSSQSQueuePolicy_basic (32.78s)
--- PASS: TestAccAWSSQSQueuePolicy_import (34.55s)
--- PASS: TestAccAWSSQSQueue_redrivePolicy (39.56s)
--- PASS: TestAccAWSSQSQueue_policy (41.75s)
--- PASS: TestAccAWSSQSQueue_Policybasic (42.96s)
--- PASS: TestAccAWSSQSQueue_basic (69.02s)
--- PASS: TestAccAWSSQSQueue_tags (72.06s)
--- PASS: TestAccAWSSQSQueue_queueDeletedRecently (111.28s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       112.552s

make testacc TESTARGS="-run=TestAccAWSSQSQueuePolicy"       
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -parallel 20 -run=TestAccAWSSQSQueuePolicy -timeout 120m
?       github.com/terraform-providers/terraform-provider-aws   [no test files]
=== RUN   TestAccAWSSQSQueuePolicy_basic
=== PAUSE TestAccAWSSQSQueuePolicy_basic
=== RUN   TestAccAWSSQSQueuePolicy_import
=== PAUSE TestAccAWSSQSQueuePolicy_import
=== CONT  TestAccAWSSQSQueuePolicy_basic
=== CONT  TestAccAWSSQSQueuePolicy_import
--- PASS: TestAccAWSSQSQueuePolicy_basic (31.57s)
--- PASS: TestAccAWSSQSQueuePolicy_import (33.63s)

[bflad]

Error messaging suggestions, otherwise LGTM 🚀

--- PASS: TestAccAWSSQSQueue_FIFOExpectNameError (7.84s)
--- PASS: TestAccAWSSQSQueue_ExpectContentBasedDeduplicationError (7.87s)
--- PASS: TestAccAWSSQSQueuePolicy_basic (13.05s)
--- PASS: TestAccAWSSQSQueue_Encryption (14.01s)
--- PASS: TestAccAWSSQSQueue_namePrefix_fifo (14.03s)
--- PASS: TestAccAWSSQSQueue_policy (14.15s)
--- PASS: TestAccAWSSQSQueue_namePrefix (14.26s)
--- PASS: TestAccAWSSQSQueue_FIFO (14.36s)
--- PASS: TestAccAWSSQSQueue_FIFOWithContentBasedDeduplication (14.47s)
--- PASS: TestAccAWSSQSQueuePolicy_import (14.80s)
--- PASS: TestAccAWSSQSQueue_redrivePolicy (15.45s)
--- PASS: TestAccAWSSQSQueue_Policybasic (15.70s)
--- PASS: TestAccAWSSQSQueue_basic (24.97s)
--- PASS: TestAccAWSSQSQueue_tags (24.95s)
--- PASS: TestAccAWSSQSQueue_queueDeletedRecently (84.52s)

[ghost]

This has been released in version 2.25.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!