-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new resource - azurerm_eventhub_namespace_authorization_rule #1572
Conversation
dad1ac4
to
92d53e3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
otherwise LGTM 👍
|
||
# azurerm_eventhub_namespace_authorization_rule | ||
|
||
Manages a Event Hub Namespace authorization Rule within an Event Hub. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Manages a Event Hub Namespace authorization Rule within an Event Hub.
-> Manages an Authorization Rule for an EventHub Namespace
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
noticed a couple of bugs in the tests
} | ||
|
||
func testCheckAzureRMEventHubNamespaceAuthorizationRuleDestroy(s *terraform.State) error { | ||
conn := testAccProvider.Meta().(*ArmClient).eventHubClient |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this wants to be using the Namespaces client
return fmt.Errorf("Bad: no resource group found in state for Event Hub: %s", name) | ||
} | ||
|
||
conn := testAccProvider.Meta().(*ArmClient).eventHubClient |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this wants to be using the Namespaces client
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks! |
No description provided.