-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update resource_arm_logic_app_trigger_http_request.go #1918
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @alastairtree,
Thank you for this fix! It LGTM, however could we get an acceptance test to verify it works?
I would suggest taking the existing test config:
func testAccAzureRMLogicAppTriggerHttpRequest_relativePath(rInt int, location string) string {
and updating the terraform to have the new characters in it (or parameterize the relative path and create a new test)
I have added a param into the existing test. Full disclosure though - I edited this without testing it myself as I am not a go developer, just capable of tweaking a dodgey regex - so worth a little scrutiny please! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thats what the tests are for 😄 and the tests all pass!
Thank you for the quick updates, LGTM 💯
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks! |
Fixes #1917 to allow http triggers with params in the relative path. See https://docs.microsoft.com/en-us/azure/logic-apps/logic-apps-http-endpoint#accept-parameters-through-your-http-endpoint-url for an example