New Resource: azurerm_monitor_activitylog_alert

[JunyiYi]

Description

In this pull request, I added a new Azure monitoring resource called activity log alerts. It will monitor the operations (such as update, delete, started, etc.) of a specific resource or all resources under one or more scope (like subscription, resource group, etc.). It is also one of the unified alerts in Azure monitor.

Related Issues

This resource will realize the requirements specified in #1252 .

References

Resource Description: https://docs.microsoft.com/en-us/azure/monitoring-and-diagnostics/monitoring-activity-log-alerts
REST API Reference: https://docs.microsoft.com/en-us/rest/api/monitor/activitylogalerts/createorupdate

[tombuildsstuff]

hey @JunyiYi

Thanks for this PR - apologies for the delayed review here! I've taken a look through and left some comments inline (mostly around the usage List vs Set) but this is off to a good start - if we can fix up the comments we should be able to take another look and kick off the tests 👍

Thanks!

[JunyiYi]

Thanks @tombuildsstuff for the review. I have changed the code accordingly. I believe the comments here also applies to another similar resource called metric alert.

[katbyte]

Hi @JunyiYi,

LGTM 👍 running tests now

[katbyte]

Tests pass:

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!