network_profile.*.ip_configuration.*.primary now required for azure_virtual_machine_scale_set

[manicminer]

The primary attribute for a VirtualMachineScaleSet IPConfiguration (https://docs.microsoft.com/en-us/rest/api/compute/virtualmachinescalesets/createorupdate#virtualmachinescalesetipconfiguration) is now apparently mandatory even with single IP configurations.

The VMs in our virtual machine scale sets only have a single interface, and each interface a single IP configuration, but we started getting this on Friday.

• azurerm_virtual_machine_scale_set.main: compute.VirtualMachineScaleSetsClient#CreateOrUpdate: Failure sending request: StatusCode=400 -- Original Error: Code="VMScaleSetNetworkInterfaceConfigurationMustHaveOneIpConfigAsPrimary" Message="Network Interface Configuration the-service-eth0 in VM Scale Set the-service-dev-vmss must have one designated primary IP Configuration." Details=[]

Discussions with an Azure support engineer confirmed this change. Simply adding the azurerm_virtual_machine_scale_set.main.network_profile.*.ip_configuration.*.primary attribute resolved the 400 error.

This is my first Terraform (actually Go project) contribution. Please let me know if I've messed up! Thanks!

[tombuildsstuff]

hey @manicminer

Thanks for this PR - this mostly LGTM, if we can fix up a couple of minor issues then this should be good to go 👍

Thanks!

[tombuildsstuff]

can we revert this? the Azure API's return the state of the resource at the last time it was modified, meaning it's possible this won't be returned (and will crash here)

[manicminer]

@tombuildsstuff Thanks for the feedback! I've updated the docs and reverted the hunk from azurerm/resource_arm_virtual_machine_scale_set.go#1161

[tombuildsstuff]

hey @manicminer

Thanks for pushing the latest changes - this now LGTM 👍 - I'll kick off the tests shortly

Thanks!

[tombuildsstuff]

hey @manicminer

Running the tests for this I notice there's a couple of configurations where the primary = true attribute is missing from the tests; so that we can get this merged - I've pushed a commit to fix this - I hope you don't mind :)

Thanks!

[tombuildsstuff]

Tests pass:

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!