Role assignment retry for service principal

[liemnotliam]

This PR looks to address issue https://github.com/terraform-providers/terraform-provider-azurerm/issues/1635, where a newly created service principal was not available for a role assignment.

There were a couple of merged PRs - PR #1647 and PR #1934 - that addressed issue https://github.com/terraform-providers/terraform-provider-azurerm/issues/1635. The role assignment create would retry, but it wouldn't retry on the error that was being returned when the created service principal wasn't available yet (400 PrincipalNotFound).

Test results for service principals:

~/go/src/github.com/terraform-providers/terraform-provider-azurerm on role-assignment-retry*
λ TESTARGS="-run TestAccAzureRMActiveDirectoryServicePrincipal_ -count=1" make testacc
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test $(go list ./... |grep -v 'vendor') -v -run TestAccAzureRMActiveDirectoryServicePrincipal_ -count=1 -timeout 180m -ldflags="-X=github.com/terraform-providers/terraform-provider-azurerm/version.ProviderVersion=acc"
?       github.com/terraform-providers/terraform-provider-azurerm       [no test files]
=== RUN   TestAccAzureRMActiveDirectoryServicePrincipal_importBasic
--- PASS: TestAccAzureRMActiveDirectoryServicePrincipal_importBasic (35.57s)
=== RUN   TestAccAzureRMActiveDirectoryServicePrincipal_basic
--- PASS: TestAccAzureRMActiveDirectoryServicePrincipal_basic (27.57s)
=== RUN   TestAccAzureRMActiveDirectoryServicePrincipal_roleAssignment
--- PASS: TestAccAzureRMActiveDirectoryServicePrincipal_roleAssignment (46.88s)
PASS
ok      github.com/terraform-providers/terraform-provider-azurerm/azurerm       110.056s
testing: warning: no tests to run
PASS
ok      github.com/terraform-providers/terraform-provider-azurerm/azurerm/helpers/authentication        0.021s [no tests to run]
testing: warning: no tests to run
PASS
ok      github.com/terraform-providers/terraform-provider-azurerm/azurerm/helpers/azure 0.041s [no tests to run]
testing: warning: no tests to run
PASS
ok      github.com/terraform-providers/terraform-provider-azurerm/azurerm/helpers/kubernetes    0.009s [no tests to run]
?       github.com/terraform-providers/terraform-provider-azurerm/azurerm/helpers/resourceproviders     [no test files]
testing: warning: no tests to run
PASS
ok      github.com/terraform-providers/terraform-provider-azurerm/azurerm/helpers/response      0.038s [no tests to run]
?       github.com/terraform-providers/terraform-provider-azurerm/azurerm/helpers/set   [no test files]
testing: warning: no tests to run
PASS
ok      github.com/terraform-providers/terraform-provider-azurerm/azurerm/helpers/suppress      0.028s [no tests to run]
testing: warning: no tests to run
PASS
ok      github.com/terraform-providers/terraform-provider-azurerm/azurerm/helpers/validate      0.017s [no tests to run]
testing: warning: no tests to run
PASS
ok      github.com/terraform-providers/terraform-provider-azurerm/azurerm/utils 0.020s [no tests to run]
?       github.com/terraform-providers/terraform-provider-azurerm/version       [no test files]

Test results for role assignments:

~/go/src/github.com/terraform-providers/terraform-provider-azurerm on role-assignment-retry*
λ TESTARGS="-run TestAccAzureRMRoleAssignment -count=1" make testacc
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test $(go list ./... |grep -v 'vendor') -v -run TestAccAzureRMRoleAssignment -count=1 -timeout 180m -ldflags="-X=github.com/terraform-providers/terraform-provider-azurerm/version.ProviderVersion=acc"
?       github.com/terraform-providers/terraform-provider-azurerm       [no test files]
=== RUN   TestAccAzureRMRoleAssignment
=== RUN   TestAccAzureRMRoleAssignment/basic
=== RUN   TestAccAzureRMRoleAssignment/basic/emptyName
=== RUN   TestAccAzureRMRoleAssignment/basic/roleName
=== RUN   TestAccAzureRMRoleAssignment/basic/dataActions
=== RUN   TestAccAzureRMRoleAssignment/basic/builtin
=== RUN   TestAccAzureRMRoleAssignment/basic/custom
=== RUN   TestAccAzureRMRoleAssignment/import
=== RUN   TestAccAzureRMRoleAssignment/import/basic
=== RUN   TestAccAzureRMRoleAssignment/import/custom
--- PASS: TestAccAzureRMRoleAssignment (269.25s)
    --- PASS: TestAccAzureRMRoleAssignment/basic (201.36s)
        --- PASS: TestAccAzureRMRoleAssignment/basic/emptyName (39.28s)
        --- PASS: TestAccAzureRMRoleAssignment/basic/roleName (35.18s)
        --- PASS: TestAccAzureRMRoleAssignment/basic/dataActions (31.04s)
        --- PASS: TestAccAzureRMRoleAssignment/basic/builtin (33.00s)
        --- PASS: TestAccAzureRMRoleAssignment/basic/custom (62.88s)
    --- PASS: TestAccAzureRMRoleAssignment/import (67.89s)
        --- PASS: TestAccAzureRMRoleAssignment/import/basic (33.18s)
        --- PASS: TestAccAzureRMRoleAssignment/import/custom (34.70s)
PASS
ok      github.com/terraform-providers/terraform-provider-azurerm/azurerm       269.282s
testing: warning: no tests to run
PASS
ok      github.com/terraform-providers/terraform-provider-azurerm/azurerm/helpers/authentication        0.022s [no tests to run]
testing: warning: no tests to run
PASS
ok      github.com/terraform-providers/terraform-provider-azurerm/azurerm/helpers/azure 0.024s [no tests to run]
testing: warning: no tests to run
PASS
ok      github.com/terraform-providers/terraform-provider-azurerm/azurerm/helpers/kubernetes    0.010s [no tests to run]
?       github.com/terraform-providers/terraform-provider-azurerm/azurerm/helpers/resourceproviders     [no test files]
testing: warning: no tests to run
PASS
ok      github.com/terraform-providers/terraform-provider-azurerm/azurerm/helpers/response      0.020s [no tests to run]
?       github.com/terraform-providers/terraform-provider-azurerm/azurerm/helpers/set   [no test files]
testing: warning: no tests to run
PASS
ok      github.com/terraform-providers/terraform-provider-azurerm/azurerm/helpers/suppress      0.023s [no tests to run]
testing: warning: no tests to run
PASS
ok      github.com/terraform-providers/terraform-provider-azurerm/azurerm/helpers/validate      0.024s [no tests to run]
testing: warning: no tests to run
PASS
ok      github.com/terraform-providers/terraform-provider-azurerm/azurerm/utils 0.021s [no tests to run]
?       github.com/terraform-providers/terraform-provider-azurerm/version       [no test files]

I'm open to suggestions and ideas towards this possible fix.

[katbyte]

Hi @liemnotliam,

Thanks for this change, it doesn't solve the root problem but its a good work around.

I hope you don't mind but i've moved the test into the role def's file, now LGTM 👍

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!