Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_network_security_rule: fixed app id read & import #2558

Merged
merged 1 commit into from
Dec 21, 2018

Conversation

katbyte
Copy link
Collaborator

@katbyte katbyte commented Dec 20, 2018

before:

==> Fixing source code with gofmt...
gofmt -s -w ./azurerm
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./azurerm -v -test.run=TestAccAzureRMNetworkSecurityRule_applicationSecurityGroups -timeout 180m -ldflags="-X=github.com/terraform-providers/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccAzureRMNetworkSecurityRule_applicationSecurityGroups
=== PAUSE TestAccAzureRMNetworkSecurityRule_applicationSecurityGroups
=== CONT  TestAccAzureRMNetworkSecurityRule_applicationSecurityGroups
--- FAIL: TestAccAzureRMNetworkSecurityRule_applicationSecurityGroups (112.99s)
    testing.go:538: Step 1 error: ImportStateVerify attributes not equivalent. Difference is shown below. Top is actual, bottom is expected.

        (map[string]string) {
        }


        (map[string]string) (len=4) {
         (string) (len=44) "destination_application_security_group_ids.#": (string) (len=1) "1",
         (string) (len=53) "destination_application_security_group_ids.2652169896": (string) (len=184) "/subscriptions//resourceGroups/acctestRG-2004195443384880969/providers/Microsoft.Network/applicationSecurityGroups/acctest-second2004195443384880969",
         (string) (len=39) "source_application_security_group_ids.#": (string) (len=1) "1",
         (string) (len=48) "source_application_security_group_ids.1551054417": (string) (len=183) "/subscriptions//resourceGroups/acctestRG-2004195443384880969/providers/Microsoft.Network/applicationSecurityGroups/acctest-first2004195443384880969"
        }

FAIL
FAIL	github.com/terraform-providers/terraform-provider-azurerm/azurerm	114.633s
make: *** [testacc] Error 1

after

==> Fixing source code with gofmt...
gofmt -s -w ./azurerm
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./azurerm -v -test.run=TestAccAzureRMNetworkSecurityRule_applicationSecurityGroups -timeout 180m -ldflags="-X=github.com/terraform-providers/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccAzureRMNetworkSecurityRule_applicationSecurityGroups
=== PAUSE TestAccAzureRMNetworkSecurityRule_applicationSecurityGroups
=== CONT  TestAccAzureRMNetworkSecurityRule_applicationSecurityGroups
--- PASS: TestAccAzureRMNetworkSecurityRule_applicationSecurityGroups (102.43s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm	104.323s

@katbyte katbyte added this to the 1.21.0 milestone Dec 20, 2018
@katbyte katbyte requested a review from a team December 20, 2018 22:44
@ghost ghost added the size/XS label Dec 20, 2018
@katbyte katbyte merged commit e38a233 into master Dec 21, 2018
@katbyte katbyte deleted the network/security_rule-appid branch December 21, 2018 01:25
katbyte added a commit that referenced this pull request Dec 21, 2018
@ghost
Copy link

ghost commented Mar 5, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants