Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow service bus subscriptions and subscription rules to start with number #2672

Merged
merged 2 commits into from
Jan 14, 2019
Merged

Allow service bus subscriptions and subscription rules to start with number #2672

merged 2 commits into from
Jan 14, 2019

Conversation

RiverPhillips
Copy link
Contributor

This PR allows subscription names and Rules to start with numbers resolving #2671

@ghost ghost added the size/XS label Jan 14, 2019
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @River991,

Thank you for the update. I've left one small comment inline and whats that rectified we can get this merged for you 🙂

azurerm/helpers/azure/servicebus.go Outdated Show resolved Hide resolved
@RiverPhillips
Copy link
Contributor Author

I just noticed the error, updated the PR

Copy link
Contributor Author

@RiverPhillips RiverPhillips left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated the PR with this fix

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @River991! LGTM now 🚀

@katbyte katbyte merged commit 9742ea5 into hashicorp:master Jan 14, 2019
katbyte added a commit that referenced this pull request Jan 14, 2019
@RiverPhillips
Copy link
Contributor Author

That's great, thanks for the fast review

@tombuildsstuff tombuildsstuff modified the milestones: 2.0.0, 1.22.0 Jan 21, 2019
@ghost
Copy link

ghost commented Mar 5, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants