azurerm_application_gateway: Support for Hostname

[mcharriere]

Added support for hostname in backend http settings. #1576

[metacpp]

@mcharriere Thanks for the contribution, mostly it LGTM, please address comments in the PR.

[katbyte]

Hi @mcharriere,

Thank you for the contribution! I've taken a look and left some comments inline. My main concern is always setting the value in the API, typically for optional values we won't set the field in the request if the property isn't set in tf.

[katbyte]

Could we get another test with 3 steps:

• set pick true
• set hostname
• unset hostname

[mcharriere]

I have a doubt regarding the test. If I set pick true and then I try to set hostname it will throw an error. Until here it's fine, i can check for that error. But I dont understand the following step. I think that unsetting hostname won't do anything because of the previous error.

Should I add a test just to check for that error (both pick and host_name set)?

[mcharriere]

@katbyte I've added the test TestAccAzureRMApplicationGateway_backendHttpSettingsHostNameAndPick checking for the error and it's passing.
Please let me know if you think there is something else to check for.

[katbyte]

As suspected i think always setting the property causes issues:

------- Stdout: -------
=== RUN   TestAccAzureRMApplicationGateway_probesPickHostNameFromBackendHTTPSettings
=== PAUSE TestAccAzureRMApplicationGateway_probesPickHostNameFromBackendHTTPSettings
=== CONT  TestAccAzureRMApplicationGateway_probesPickHostNameFromBackendHTTPSettings
--- FAIL: TestAccAzureRMApplicationGateway_probesPickHostNameFromBackendHTTPSettings (107.04s)
    testing.go:538: Step 0 error: Error applying: 1 error occurred:
        	* azurerm_application_gateway.test: 1 error occurred:
        	* azurerm_application_gateway.test: Error Creating/Updating Application Gateway "acctestag-190305192949044967" (Resource Group "acctestRG-190305192949044967"): network.ApplicationGatewaysClient#CreateOrUpdate: Failure sending request: StatusCode=400 -- Original Error: Code="ApplicationGatewayBackendHttpSettingsHostNameFieldConflict" Message="HostName field may only be specified if pickHostNameFromBackendAddress is set to false in context '/subscriptions/c0a607b2-6372-4ef3-abdb-dbe52a7b56ba/resourceGroups/acctestRG-190305192949044967/providers/Microsoft.Network/applicationGateways/acctestag-190305192949044967/backendHttpSettingsCollection/acctest-vnet-190305192949044967-be-htst'." Details=[]

superseded

[mcharriere]

Oh @katbyte thanks for pointing out that. I'll fix it soon.

[katbyte]

Thanks for the updates @mcharriere!

this LGTM now 👍

[ghost]

This has been released in version 1.24.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
	version = "~> 1.24.0"
}
# ... other configuration ...

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!