Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Resource: azurerm_api_management_api #3010

Merged
merged 38 commits into from
Mar 15, 2019
Merged

New Resource: azurerm_api_management_api #3010

merged 38 commits into from
Mar 15, 2019

Conversation

tombuildsstuff
Copy link
Contributor

Continuing working through #1177

This PR implements the azurerm_api_management_api resource based on the work done by @torresdal in #2073

@tombuildsstuff tombuildsstuff added this to the 1.23.0 milestone Mar 6, 2019
tombuildsstuff
tombuildsstuff commented Mar 6, 2019
View reviewed changes
azurerm/provider.go Outdated Show resolved Hide resolved
@tombuildsstuff tombuildsstuff requested a review from a team March 6, 2019 14:19
@tombuildsstuff tombuildsstuff modified the milestones: 1.23.0, 1.25.0 Mar 6, 2019
@tombuildsstuff
Copy link
Contributor Author

Resource Tests pass:

screenshot 2019-03-06 at 16 18 21

katbyte
katbyte approved these changes Mar 11, 2019
View reviewed changes
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from a couple minor comments LGTM 👍

azurerm/data_source_api_management_api_test.go Outdated Show resolved Hide resolved
azurerm/resource_arm_api_management_api.go Show resolved Hide resolved
azurerm/resource_arm_api_management_api.go Show resolved Hide resolved
azurerm/resource_arm_api_management_api.go Show resolved Hide resolved
azurerm/resource_arm_api_management_api.go Show resolved Hide resolved
azurerm/resource_arm_api_management_api.go Show resolved Hide resolved
azurerm/resource_arm_api_management_api.go Show resolved Hide resolved
@tombuildsstuff tombuildsstuff modified the milestones: v1.25.0, v1.24.0 Mar 14, 2019
@torresdal @tombuildsstuff
Added basic support for API Management API
86f7705
@torresdal @tombuildsstuff
Cleaned up unused schema elements of API Management API
e97cb7d
@torresdal @tombuildsstuff
Added docs for api_management_api resource
14eba35
@torresdal @tombuildsstuff
Added missing fields to schema
8ab94d1
@torresdal @tombuildsstuff
Cleaned up, tested and added data to schema fields
308f7d3
@torresdal @tombuildsstuff
Cleanup:
5e0b3bc 
* Replaced soap_api_type with bool soap_pass_through
* Added validation for api path and name
* Added validation tests for api path and name
@torresdal @tombuildsstuff
Updated docs for API Management API resource and data to reflect rece…
7e60e9e 
…nt changes
@torresdal @tombuildsstuff
Fixed sidebar issues in doc
8ccd016
@torresdal @tombuildsstuff
Removed display_name option - name works for both
4b2f6bf
@torresdal @tombuildsstuff
Add simple test for data source
e9de296
@torresdal @tombuildsstuff
Add simple test for API Management API
3c8b334
@torresdal @tombuildsstuff
Testing:
046e7f3 
* Fixed basic data test and include more props to check
* Replaced test data with files instead of pointing to urls
* Add complete test for API Management API
@torresdal @tombuildsstuff
Fixed error found in integration tests:
93cd651 
* Ignore import, since state is only persisted in Terraform
* Removed location from schema
* Add seperate get after creating resource to get ID
tombuildsstuff and others added 18 commits March 15, 2019 13:51
@tombuildsstuff @torresdal
Grammar improvement
530929a 
Co-Authored-By: torresdal <jon@torresdal.net>
@torresdal @tombuildsstuff
Fixed and made changes according to review
4134a35
@torresdal @tombuildsstuff
Fixed failing test by removing Computed on revision for api-managemen…
28daf66 
…t-api data source
@torresdal @tombuildsstuff
Replaced ip's with int.test url in example wsdl using for int.test
f83994a
@torresdal @tombuildsstuff
Fixed issues after running int.tests.
13119ac
@torresdal @tombuildsstuff
Don't mix name and display_name, seperate them as in azure api
0c75f2f
@torresdal @tombuildsstuff
Simplyfied create/update with/without import api
4d8f6f3
@torresdal @tombuildsstuff
Documented display name. Removed defaults for header and query
2fad08d
@torresdal @tombuildsstuff
Fixed empty return statements
2460dda
@torresdal @tombuildsstuff
Removed unused props var
d4a2981
@torresdal @tombuildsstuff
Fixed issue where display_name is a mandatory value for the Azure API
af6606c
@torresdal @tombuildsstuff
Added missing display_name to int. tests
ef0d918
@tombuildsstuff
fixing the build
425d7dd
@tombuildsstuff
refactoring
710b3f8
@tombuildsstuff
fixing a bad merge conflict
3d86e68
@tombuildsstuff
Refactoring azurerm_api_management_api
90931f8
@tombuildsstuff
Adding back in the resources missing from a bad merge conflict with m…
2c00119 
…aster
@tombuildsstuff
Fixing the failing test
d4f836d
@tombuildsstuff tombuildsstuff force-pushed the f/api-management-api branch 2 times, most recently from b50ed4f to 34e10fa Compare March 15, 2019 15:26
@tombuildsstuff
Copy link
Contributor Author

Resource tests pass:

Screenshot 2019-03-15 at 17 10 58

Data Source tests pass:

Screenshot 2019-03-15 at 17 11 22

@tombuildsstuff tombuildsstuff merged commit 7565458 into master Mar 15, 2019
@tombuildsstuff tombuildsstuff deleted the f/api-management-api branch March 15, 2019 16:11
tombuildsstuff added a commit that referenced this pull request Mar 15, 2019
@tombuildsstuff
Updating to include #3010
a6910e4
@tombuildsstuff tombuildsstuff mentioned this pull request Mar 18, 2019
Closed
@ghost
Copy link

ghost commented Apr 3, 2019

This has been released in version 1.24.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
	version = "~> 1.24.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Apr 15, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@metacpp metacpp metacpp left review comments

@katbyte katbyte katbyte approved these changes

Assignees
No one assigned
Labels
documentation new-data-source new-resource service/api-management size/XXL
Projects
None yet
Milestone
v1.24.0
Development

Successfully merging this pull request may close these issues.
4 participants
@tombuildsstuff @katbyte @metacpp @torresdal