Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/app_service: support for migrating between App Service Plans #3048

Merged
merged 1 commit into from
Mar 15, 2019

Conversation

tombuildsstuff
Copy link
Contributor

Fixes #3036

Tests pass:

$ acctests azurerm TestAccAzureRMAppService_movingAppService
=== RUN   TestAccAzureRMAppService_movingAppService
=== PAUSE TestAccAzureRMAppService_movingAppService
=== CONT  TestAccAzureRMAppService_movingAppService
--- PASS: TestAccAzureRMAppService_movingAppService (236.65s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm	237.249s

Fixes #3036

Tests pass:

```
$ acctests azurerm TestAccAzureRMAppService_movingAppService
=== RUN   TestAccAzureRMAppService_movingAppService
=== PAUSE TestAccAzureRMAppService_movingAppService
=== CONT  TestAccAzureRMAppService_movingAppService
--- PASS: TestAccAzureRMAppService_movingAppService (236.65s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm	237.249s
```
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@tombuildsstuff
Copy link
Contributor Author

Tests pass:

Screenshot 2019-03-15 at 13 57 37

@tombuildsstuff tombuildsstuff merged commit 69a5367 into master Mar 15, 2019
@tombuildsstuff tombuildsstuff deleted the f/moving-app-service branch March 15, 2019 12:57
tombuildsstuff added a commit that referenced this pull request Mar 15, 2019
@ghost
Copy link

ghost commented Apr 3, 2019

This has been released in version 1.24.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
	version = "~> 1.24.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Apr 14, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Moving Azure App Service to a different App Service Plan causes a create and destroy.
2 participants