-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Eventhub property skip empty archives #3074
Eventhub property skip empty archives #3074
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the PR @Lucretius, while not ideal the property matches the SDK/API and most likely the docs online so i think it's fine as is 🙂 LGTM 👍
This has been released in version 1.24.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 1.24.0"
}
# ... other configuration ... |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks! |
Resolves #3057
Two questions
I've altered the event hub tests to use a fully-configurable capture description (in case we want to expand on test cases later on down the road). I first tried just re-created the capture description struct to match the struct in the resource itself, then I pulled in the(Opted to simplify testing for sake of ease-of-understanding)github.com/Azure/azure-sdk-for-go/services/eventhub/mgmt/2017-04-01/eventhub
dependency and relied directly on the source models. Which is best practice?The field itself is a bit hard to describe without using a double negative. The SDK referred to it as
SkipEmptyArchives
, which will not emit empty files if no events occur in the capture window. Any suggestions for verbiage or this is easy enough to read?Feel free to review and I can adjust accordingly.