-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
iothub IP filters #3173
iothub IP filters #3173
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey @Lucretius
Thanks for this PR :)
Taking a through this mostly LGTM - if we can fix up the minor comments then this should be good to merge 👍
Thanks!
Co-Authored-By: Lucretius <rlippens39@gmail.com>
Co-Authored-By: Lucretius <rlippens39@gmail.com>
Co-Authored-By: Lucretius <rlippens39@gmail.com>
I've added the desired changes. Thanks for the feedback! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the revisions @Lucretius, Aside from one minor comment this LGTM 👍
dismissing since changes have been pushed
@tombuildsstuff not a problem, thanks for doing that! |
This has been released in version 1.25.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 1.25.0"
}
# ... other configuration ... |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks! |
Resolves #1699 by adding the ability to configure IP Filter rules for the iothub resource. Updated the documentation accordingly and added a test.