Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/batch_account & r/batch_pool: temporarily treating the resource group name as case insensitive #3260

Merged
merged 1 commit into from
Apr 16, 2019

Conversation

tombuildsstuff
Copy link
Contributor

Whilst some Azure API's treat Resource ID's as case insensitive, others (particularly where they take Resource ID's from other resources) don't - as such Terraform intentionally treats Resource ID's as case sensitive.

Unfortunately the Batch API returns Resource ID's in the incorrect case which means we're forced to treat the Resource Group Name as case insensitive until this API bug is resolved.

@tombuildsstuff tombuildsstuff added bug upstream/microsoft Indicates that there's an upstream issue blocking this issue/PR service/batch labels Apr 16, 2019
@tombuildsstuff tombuildsstuff added this to the v1.25.0 milestone Apr 16, 2019
@tombuildsstuff tombuildsstuff requested a review from a team April 16, 2019 11:26
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@tombuildsstuff tombuildsstuff merged commit 205d9a4 into master Apr 16, 2019
@tombuildsstuff tombuildsstuff deleted the b/batch-resource-group branch April 16, 2019 18:47
tombuildsstuff added a commit that referenced this pull request Apr 16, 2019
@ghost
Copy link

ghost commented Apr 17, 2019

This has been released in version 1.25.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
	version = "~> 1.25.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented May 17, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators May 17, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug documentation service/batch size/XS upstream/microsoft Indicates that there's an upstream issue blocking this issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants