Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Resource: azurerm_key_vault_key #356

Merged
merged 2 commits into from
Sep 27, 2017
Merged

New Resource: azurerm_key_vault_key #356

merged 2 commits into from
Sep 27, 2017

Conversation

tombuildsstuff
Copy link
Contributor

Also fixes the import test for Key Vault Secret

Tests pass:

$ acctests azurerm TestAccAzureRMKeyVaultKey_
=== RUN   TestAccAzureRMKeyVaultKey_importBasicEC
--- PASS: TestAccAzureRMKeyVaultKey_importBasicEC (70.70s)
=== RUN   TestAccAzureRMKeyVaultKey_importBasicRSA
--- PASS: TestAccAzureRMKeyVaultKey_importBasicRSA (68.10s)
=== RUN   TestAccAzureRMKeyVaultKey_importBasicRSAHSM
--- PASS: TestAccAzureRMKeyVaultKey_importBasicRSAHSM (70.66s)
=== RUN   TestAccAzureRMKeyVaultKey_importComplete
--- PASS: TestAccAzureRMKeyVaultKey_importComplete (72.80s)
=== RUN   TestAccAzureRMKeyVaultKey_basicEC
--- PASS: TestAccAzureRMKeyVaultKey_basicEC (77.62s)
=== RUN   TestAccAzureRMKeyVaultKey_basicRSA
--- PASS: TestAccAzureRMKeyVaultKey_basicRSA (75.13s)
=== RUN   TestAccAzureRMKeyVaultKey_basicRSAHSM
--- PASS: TestAccAzureRMKeyVaultKey_basicRSAHSM (73.56s)
=== RUN   TestAccAzureRMKeyVaultKey_complete
--- PASS: TestAccAzureRMKeyVaultKey_complete (77.08s)
=== RUN   TestAccAzureRMKeyVaultKey_update
--- PASS: TestAccAzureRMKeyVaultKey_update (85.13s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm	670.796s
$ acctests azurerm TestAccAzureRMKeyVaultSecret_
=== RUN   TestAccAzureRMKeyVaultSecret_importBasic
--- PASS: TestAccAzureRMKeyVaultSecret_importBasic (75.95s)
=== RUN   TestAccAzureRMKeyVaultSecret_importComplete
--- PASS: TestAccAzureRMKeyVaultSecret_importComplete (77.15s)
=== RUN   TestAccAzureRMKeyVaultSecret_parseID
--- PASS: TestAccAzureRMKeyVaultSecret_parseID (0.00s)
=== RUN   TestAccAzureRMKeyVaultSecret_basic
--- PASS: TestAccAzureRMKeyVaultSecret_basic (80.03s)
=== RUN   TestAccAzureRMKeyVaultSecret_complete
--- PASS: TestAccAzureRMKeyVaultSecret_complete (73.73s)
=== RUN   TestAccAzureRMKeyVaultSecret_update
--- PASS: TestAccAzureRMKeyVaultSecret_update (86.54s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm	393.426s

The following attributes are exported:

* `id` - The Key Vault Key ID.
* `version` - The current version of the Key Vault Key.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You set the n and e attributes in the read function. Do we want to talk about those here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point - updated

Also fixes an issue where the Key Vault Secret Import Tests weren't running properly
Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tombuildsstuff tombuildsstuff merged commit 3bc8e3f into master Sep 27, 2017
@tombuildsstuff tombuildsstuff deleted the keyvault-key branch September 27, 2017 14:59
tombuildsstuff added a commit that referenced this pull request Sep 27, 2017
@ghost
Copy link

ghost commented Apr 1, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants