Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New resource: azurerm_private_dns_zone #3718

Merged
merged 2 commits into from
Jun 27, 2019
Merged

Conversation

timja
Copy link
Contributor

@timja timja commented Jun 23, 2019

Fixes #3714

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @timja, LGTM 👍

@katbyte katbyte added this to the v1.31.0 milestone Jun 27, 2019
katbyte added a commit that referenced this pull request Jun 27, 2019
@katbyte katbyte merged commit 0025db8 into hashicorp:master Jun 27, 2019
@ghost
Copy link

ghost commented Jun 28, 2019

This has been released in version 1.31.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 1.31.0"
}
# ... other configuration ...

@bentterp
Copy link
Contributor

bentterp commented Jul 1, 2019

This is good!
I just can't figure out how to use it for VNET auto-registrations. Do we have another resource type coming for that, or am I just not getting it? Tried creating a link in the portal and then generating a plan, no changes required.

@timja
Copy link
Contributor Author

timja commented Jul 1, 2019

It needs a new resource type, no issue created for it yet AFAIK.
I just created the first resource required for private dns.

@timja timja deleted the private-dns branch July 1, 2019 06:41
@bentterp
Copy link
Contributor

bentterp commented Jul 1, 2019

#3758

I'm quite good at creating issues, no good at writing the code for the PR's.... 😊

@ghost
Copy link

ghost commented Jul 28, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Jul 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Private DNS Zones
3 participants