-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Resource: azurerm_mariadb_virtual_network_rule
#4048
New Resource: azurerm_mariadb_virtual_network_rule
#4048
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @dintskirveli,
Thank you for this PR. In addition to the comment i've left inline that indicates we might not need the subnet fix, could we get some documentation and tests added?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the revisions @dintskirveli, LGTM now 👍
azurerm_mariadb_virtual_network_rule
@@ -261,7 +261,7 @@ resource "azurerm_mariadb_server" "test" { | |||
resource_group_name = "${azurerm_resource_group.test.name}" | |||
administrator_login = "acctestun" | |||
administrator_login_password = "H@Sh1CoR3!" | |||
version = "5.6" | |||
version = "10.2" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, thanks @katbyte! Still working out app credentials to get acceptance tests to run on our end.
This has been released in version 1.33.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 1.33.0"
}
# ... other configuration ... |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks! |
No description provided.