Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Resource: azurerm_mariadb_virtual_network_rule #4048

Merged
merged 5 commits into from
Aug 18, 2019

Conversation

dintskirveli
Copy link
Contributor

No description provided.

@ghost ghost added the size/L label Aug 9, 2019
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @dintskirveli,

Thank you for this PR. In addition to the comment i've left inline that indicates we might not need the subnet fix, could we get some documentation and tests added?

@ghost ghost added size/XL and removed size/L labels Aug 14, 2019
@ghost ghost added the documentation label Aug 17, 2019
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the revisions @dintskirveli, LGTM now 👍

@katbyte katbyte changed the title Add resource for setup up vnet rules on MariaDB servers New Resource: azurerm_mariadb_virtual_network_rule Aug 18, 2019
@katbyte katbyte merged commit fc4443e into hashicorp:master Aug 18, 2019
@katbyte katbyte modified the milestones: v1.34.0, v1.33.0 Aug 18, 2019
katbyte added a commit that referenced this pull request Aug 18, 2019
@@ -261,7 +261,7 @@ resource "azurerm_mariadb_server" "test" {
resource_group_name = "${azurerm_resource_group.test.name}"
administrator_login = "acctestun"
administrator_login_password = "H@Sh1CoR3!"
version = "5.6"
version = "10.2"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, thanks @katbyte! Still working out app credentials to get acceptance tests to run on our end.

@ghost
Copy link

ghost commented Aug 22, 2019

This has been released in version 1.33.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 1.33.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Sep 18, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Sep 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants