Support multiple alternative locations for azurerm_api_management

[pdecat]

Resolves #4171

[nexxai]

This change looks like it adds a second location, but in the original requester's post, he gives an example of 3 additional_location blocks. Is there a way to make this more flexible, rather than just hard coding a set number of them?

[pdecat]

This changes allows any number of alternative locations.

It is just the acceptance test that tests with two alternative locations.

[nexxai]

Man, I think I need my coffee. Can't believe I missed that. Sorry.

[pdecat]

Acceptance test result:

# make testacc TEST=./azurerm TESTARGS='-run=TestAccAzureRMApiManagement_complete'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./azurerm -v -run=TestAccAzureRMApiManagement_complete -timeout 180m -ldflags="-X=github.com/terraform-providers/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccAzureRMApiManagement_complete
=== PAUSE TestAccAzureRMApiManagement_complete
=== CONT  TestAccAzureRMApiManagement_complete
--- PASS: TestAccAzureRMApiManagement_complete (1571.92s)
PASS
ok      github.com/terraform-providers/terraform-provider-azurerm/azurerm       1571.951s

[tombuildsstuff]

hey @pdecat

Thanks for this PR - taking a look through this LGTM - I'll kick off the tests shortly 👍

Thanks!

[tombuildsstuff]

Tests pass:

Thanks again @pdecat :)

[pdecat]

Great, thanks @tombuildsstuff!

[ghost]

This has been released in version 1.34.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 1.34.0"
}
# ... other configuration ...

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!