New Resource: azurerm_app_service_certificate

[joakimhellum]

Reference to #1136

TODO:

• Change key_vault_secret_name to key_vault_secret_id

[tombuildsstuff]

hey @joakimhellum-in

Thanks for this PR - taking a look through I've left a few extra comments in addition to the name -> id change - but this is otherwise looking pretty good 👍

Thanks!

[tombuildsstuff]

thinking about this - would it be worth inferring the Key Vault ID from the Key Vault Secret ID so users didn't need to specify both fields?

[joakimhellum]

This would be very nice. However the Key Vault Secret ID is in format {vaultBaseUrl}/certificates/{certificateName}/{certificateVersion} so on top of the head not completely sure how to best manage this. Will investigate this during weekend.

[tombuildsstuff]

good point - FWIW we look this up for the Key Vault child resources (e.g. certificates, keys, secrets) - so it should be possible to reuse the same technique (which calls into this method) :)

[joakimhellum]

Thanks 🤯 Have made an attempt to reuse this.

[joakimhellum]

@tombuildsstuff Many thanks for all your help on this. It should be ready for proper review now.

[katbyte]

Thanks for the revisions @joakimhellum-in, Looks great aside from a few comments i've left inline. Looks like your setting a property that doesn't exist in the schema.

[joakimhellum]

@katbyte Thanks for this 😸 Will remember to run test and acctest next time, and fmt on test configurations.

--- PASS: TestAccAzureRMAppServiceCertificate_Pfx (94.06s)
--- PASS: TestAccAzureRMAppServiceCertificate_PfxNoPassword (95.18s)
--- PASS: TestAccAzureRMAppServiceCertificate_KeyVault (230.18s)

[katbyte]

No worries! I have a tool in progress that can auto format the blocks fairly well here: https://github.com/katbyte/terrafmt

[katbyte]

Thanks for the changes @joakimhellum-in! LGTM now 🙂

[ghost]

This has been released in version 1.34.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 1.34.0"
}
# ... other configuration ...

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!