Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Resource: azurerm_kusto_eventhub_data_connection #4385

Merged

Conversation

jrauschenbusch
Copy link
Contributor

As discussed here with @r0bnet an initial version for EventHub data connection resource.

Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @jrauschenbusch

Thanks for this PR - apologies for the delayed review here

Taking a look through this mostly LGTM - if we can fix up the minor comments this otherwise LGTM 👍

Thanks!

azurerm/resource_arm_kusto_eventhub_data_connection.go Outdated Show resolved Hide resolved
@tombuildsstuff tombuildsstuff added this to the v1.35.0 milestone Sep 26, 2019
@tombuildsstuff tombuildsstuff modified the milestones: v1.35.0, v1.36.0 Oct 1, 2019
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the revisions @jrauschenbusch ! LGTM 👍

@katbyte katbyte changed the title New Resource: Kusto EventHub Data Connection New Resource: azurerm_kusto_eventhub_data_connection Oct 8, 2019
@katbyte katbyte merged commit 3c435db into hashicorp:master Oct 8, 2019
katbyte added a commit that referenced this pull request Oct 8, 2019
@ghost
Copy link

ghost commented Oct 29, 2019

This has been released in version 1.36.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 1.36.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Nov 8, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Nov 8, 2019
@jrauschenbusch jrauschenbusch deleted the kusto-eventhub-data-connection branch March 1, 2020 00:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants