-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
azurerm_cosmosdb_mongo_collection - add support for the throughput
property
#4467
Conversation
throughput
support for Cosmos DB Mongo CollectionThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @kmfk, Overall looks pretty good, once the few comments i've let inline are addressed this should be good to merge!
@katbyte I believe this is good. Pretty much all CosmosDB resources can use the I don't mind adding support for the rest of the resources - do you prefer a separate PR for those? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes @kmfk! LGTM 👍
And yes if you don't mind adding them that would be wonderful 🙂 you are correct they weren't part of the SDK when these resources were written!
throughput
property
Hii @kmfk, just wanted to ask if you plan to open a PR to add support for defining throughput also for other resources? We would be excited to see it in the case of database creation. Thanks. |
@ragoragino Yeah, I'll take a stab at the others |
This has been released in version 1.36.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 1.36.0"
}
# ... other configuration ... |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks! |
This would resolve #3586 and allow setting the
throughput
property on the collection.There are several places where support should be added for
throughput
on the Cosmos DB resources. If this ok, I can add in the others.