Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_cosmosdb_mongo_collection - add support for the throughput property #4467

Merged
merged 6 commits into from
Oct 5, 2019

Conversation

k-k
Copy link
Contributor

@k-k k-k commented Sep 30, 2019

This would resolve #3586 and allow setting the throughput property on the collection.

There are several places where support should be added for throughput on the Cosmos DB resources. If this ok, I can add in the others.

@k-k k-k changed the title Adds throughput support for Cosmos DB Mongo Collection Adds throughput support for Cosmos DB Mongo Collection Sep 30, 2019
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @kmfk, Overall looks pretty good, once the few comments i've let inline are addressed this should be good to merge!

website/docs/r/cosmosdb_mongo_collection.html.markdown Outdated Show resolved Hide resolved
azurerm/resource_arm_cosmosdb_mongo_collection.go Outdated Show resolved Hide resolved
@ghost ghost added size/L and removed size/S labels Oct 1, 2019
@k-k
Copy link
Contributor Author

k-k commented Oct 1, 2019

@katbyte I believe this is good.

Pretty much all CosmosDB resources can use the throughput parameter, but I believe support for it was added to the go sdk after these CosmosDB resources were added to this provider.

I don't mind adding support for the rest of the resources - do you prefer a separate PR for those?

@ghost ghost removed the waiting-response label Oct 1, 2019
@k-k k-k requested a review from katbyte October 1, 2019 20:03
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes @kmfk! LGTM 👍

And yes if you don't mind adding them that would be wonderful 🙂 you are correct they weren't part of the SDK when these resources were written!

@katbyte katbyte merged commit 0caed50 into hashicorp:master Oct 5, 2019
@katbyte katbyte changed the title Adds throughput support for Cosmos DB Mongo Collection azurerm_cosmosdb_mongo_collection - add support for the throughput property Oct 5, 2019
katbyte added a commit that referenced this pull request Oct 5, 2019
@k-k k-k deleted the cosmosdb-throughput-support branch October 9, 2019 23:43
@ragoragino
Copy link

Hii @kmfk,

just wanted to ask if you plan to open a PR to add support for defining throughput also for other resources? We would be excited to see it in the case of database creation.

Thanks.

@k-k
Copy link
Contributor Author

k-k commented Oct 10, 2019

@ragoragino Yeah, I'll take a stab at the others

@ghost
Copy link

ghost commented Oct 29, 2019

This has been released in version 1.36.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 1.36.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Nov 4, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Nov 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow to specify throughput for azurerm_cosmosdb_mongo_collection
4 participants